Commit 2a46dae3 authored Jun 07, 2011 by Nikunj A. Dadhania Committed by Ingo Molnar Jul 01, 2011

sched: Remove rcu_read_lock() from wake_affine()



wake_affine() is only called from one path: select_task_rq_fair(),
which already has the RCU read lock held.

Signed-off-by: Nikunj A. Dadhania <nikunj@linux.vnet.ibm.com>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Link: http://lkml.kernel.org/r/20110607101251.777.34547.stgit@IBM-009124035060.in.ibm.com


Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 36b2e922

kernel/sched_fair.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -1481,7 +1481,6 @@ static int wake_affine(struct sched_domain sd, struct task_struct p, int sync)
		* effect of the currently running task from the load
		* of the current CPU:
		*/
		rcu_read_lock();
		if (sync) {
		tg = task_group(current);
		weight = current->se.load.weight;
		@@ -1517,7 +1516,6 @@ static int wake_affine(struct sched_domain sd, struct task_struct p, int sync)
		balanced = this_eff_load <= prev_eff_load;
		} else
		balanced = true;
		rcu_read_unlock();

		/*
		* If the currently running task will sleep within

Admin message