arm64: vdso: Fix unusual formatting in *setup_additional_pages() (2a30aca8) · Commits · 戴 / test

There's really no need to put every parameter on a new line when calling a function with a long name, so reformat the *setup_additional_pages() functions in the vDSO setup code to follow the usual conventions. Acked-by:

Mark Rutland <mark.rutland@arm.com> Reviewed-by:

Vincenzo Frascino <vincenzo.frascino@arm.com> Reviewed-by:

Ard Biesheuvel <ardb@kernel.org> Signed-off-by:

Will Deacon <will@kernel.org>

arch/arm64/kernel/vdso.c

+3 −10

Original line number	Diff line number	Diff line
		@@ -440,9 +440,7 @@ int aarch32_setup_additional_pages(struct linux_binprm *bprm, int uses_interp)
		goto out;

		if (IS_ENABLED(CONFIG_COMPAT_VDSO)) {
		ret = __setup_additional_pages(VDSO_ABI_AA32,
		mm,
		bprm,
		ret = __setup_additional_pages(VDSO_ABI_AA32, mm, bprm,
		uses_interp);
		if (ret)
		goto out;
		@@ -487,8 +485,7 @@ static int __init vdso_init(void)
		}
		arch_initcall(vdso_init);

		int arch_setup_additional_pages(struct linux_binprm *bprm,
		int uses_interp)
		int arch_setup_additional_pages(struct linux_binprm *bprm, int uses_interp)
		{
		struct mm_struct *mm = current->mm;
		int ret;
		@@ -496,11 +493,7 @@ int arch_setup_additional_pages(struct linux_binprm *bprm,
		if (mmap_write_lock_killable(mm))
		return -EINTR;

		ret = __setup_additional_pages(VDSO_ABI_AA64,
		mm,
		bprm,
		uses_interp);

		ret = __setup_additional_pages(VDSO_ABI_AA64, mm, bprm, uses_interp);
		mmap_write_unlock(mm);

		return ret;

Admin message