Commit 2a27753f authored Sep 16, 2010 by Vikram Pandita Committed by Santosh Shilimkar Sep 24, 2010

omap: sram: fix is_sram_locked check



For OMAP24xx/34xx/44xx: omap_type() returns the correct type:
 OMAP2_DEVICE_TYPE_TEST
 OMAP2_DEVICE_TYPE_EMU
 OMAP2_DEVICE_TYPE_SEC
 OMAP2_DEVICE_TYPE_GP
 OMAP2_DEVICE_TYPE_BAD

In current implementation there are two problems:
Problem 1:
For 34xx, the current if check will never return true.

Problem 2:
For 24xx the correct type check should be with omap_type() function
Verified by checking the TRM 24xx for CONTROL_STATUS register bits

Signed-off-by: Vikram Pandita <vikram.pandita@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>

parent b30a3f62

arch/arm/plat-omap/sram.c

+1 −10

Original line number	Diff line number	Diff line
		@@ -93,16 +93,7 @@ extern unsigned long omapfb_reserve_sram(unsigned long sram_pstart,
		*/
		static int is_sram_locked(void)
		{
		int type = 0;

		if (cpu_is_omap44xx())
		/* Not yet supported */
		return 0;

		if (cpu_is_omap242x())
		type = omap_rev() & OMAP2_DEVICETYPE_MASK;

		if (type == GP_DEVICE) {
		if (OMAP2_DEVICE_TYPE_GP == omap_type()) {
		/* RAMFW: R/W access to all initiators for all qualifier sets */
		if (cpu_is_omap242x()) {
		__raw_writel(0xFF, OMAP24XX_VA_REQINFOPERM0); /* all q-vects */

Admin message