Commit 2a189f9e authored Nov 04, 2015 by Sabrina Dubroca Committed by David S. Miller Nov 04, 2015

ipv6: clean up dev_snmp6 proc entry when we fail to initialize inet6_dev



In ipv6_add_dev, when addrconf_sysctl_register fails, we do not clean up
the dev_snmp6 entry that we have already registered for this device.
Call snmp6_unregister_dev in this case.

Fixes: a317a2f1 ("ipv6: fail early when creating netdev named all or default")
Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 87aec47d

net/ipv6/addrconf.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -418,6 +418,7 @@ static struct inet6_dev ipv6_add_dev(struct net_device dev)
		if (err) {
		ipv6_mc_destroy_dev(ndev);
		del_timer(&ndev->regen_timer);
		snmp6_unregister_dev(ndev);
		goto err_release;
		}
		/* protected by rtnl_lock */

Admin message