Commit 2a121030 authored Jan 25, 2019 by Lucas De Marchi Committed by Jani Nikula Feb 05, 2019

drm/i915: always return something on DDI clock selection



Even if we don't have the correct clock and get a warning, we should not
skip the return.

v2: improve commit message (from Joonas)

Fixes: 1fa11ee2 ("drm/i915/icl: start adding the TBT pll")
Cc: Paulo Zanoni <paulo.r.zanoni@intel.com>
Cc: <stable@vger.kernel.org> # v4.19+
Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190125222444.19926-3-lucas.demarchi@intel.com


(cherry picked from commit 7a61a6de)
Signed-off-by: Jani Nikula <jani.nikula@intel.com>

parent 3e0b69bb

drivers/gpu/drm/i915/intel_ddi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1086,7 +1086,7 @@ static uint32_t icl_pll_to_ddi_pll_sel(struct intel_encoder *encoder,
		return DDI_CLK_SEL_TBT_810;
		default:
		MISSING_CASE(clock);
		break;
		return DDI_CLK_SEL_NONE;
		}
		case DPLL_ID_ICL_MGPLL1:
		case DPLL_ID_ICL_MGPLL2:

Admin message