Commit 2a028ecb authored Nov 18, 2015 by Eric Dumazet Committed by David S. Miller Nov 18, 2015

net: allow BH servicing in sk_busy_loop()



Instead of blocking BH in whole sk_busy_loop(), block them
only around ->ndo_busy_poll() calls.

This has many benefits.

1) allow tunneled traffic to use busy poll as well as native traffic.
   Tunnels handlers usually call netif_rx() and depend on net_rx_action()
   being run (from sofirq handler)

2) allow RFS/RPS being used (sending IPI to other cpus if needed)

3) use the 'lets burn cpu cycles' budget to do useful work
   (like TX completions, timers, RCU callbacks...)

4) reduce BH latencies, making busy poll a better citizen.

Tested:

Tested with SIT tunnel

lpaa5:~# echo 0 >/proc/sys/net/core/busy_read
lpaa5:~# ./netperf -H 2002:af6:786::1 -t TCP_RR
MIGRATED TCP REQUEST/RESPONSE TEST from ::0 (::) port 0 AF_INET6 to 2002:af6:786::1 () port 0 AF_INET6 : first burst 0
Local /Remote
Socket Size   Request  Resp.   Elapsed  Trans.
Send   Recv   Size     Size    Time     Rate
bytes  Bytes  bytes    bytes   secs.    per sec

16384  87380  1        1       10.00    37373.93
16384  87380

Now enable busy poll on both hosts

lpaa5:~# echo 70 >/proc/sys/net/core/busy_read
lpaa6:~# echo 70 >/proc/sys/net/core/busy_read

lpaa5:~# ./netperf -H 2002:af6:786::1 -t TCP_RR
MIGRATED TCP REQUEST/RESPONSE TEST from ::0 (::) port 0 AF_INET6 to 2002:af6:786::1 () port 0 AF_INET6 : first burst 0
Local /Remote
Socket Size   Request  Resp.   Elapsed  Trans.
Send   Recv   Size     Size    Time     Rate
bytes  Bytes  bytes    bytes   secs.    per sec

16384  87380  1        1       10.00    58314.77
16384  87380

Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 02d62e86

net/core/dev.c

+7 −11

Original line number	Diff line number	Diff line
		@@ -4684,11 +4684,7 @@ bool sk_busy_loop(struct sock *sk, int nonblock)
		struct napi_struct *napi;
		int rc = false;

		/*
		* rcu read lock for napi hash
		* bh so we don't race with net_rx_action
		*/
		rcu_read_lock_bh();
		rcu_read_lock();

		napi = napi_by_id(sk->sk_napi_id);
		if (!napi)
		@@ -4699,23 +4695,23 @@ bool sk_busy_loop(struct sock *sk, int nonblock)
		goto out;

		do {
		local_bh_disable();
		rc = ops->ndo_busy_poll(napi);
		if (rc > 0)
		NET_ADD_STATS_BH(sock_net(sk),
		LINUX_MIB_BUSYPOLLRXPACKETS, rc);
		local_bh_enable();

		if (rc == LL_FLUSH_FAILED)
		break; /* permanent failure */

		if (rc > 0)
		/* local bh are disabled so it is ok to use _BH */
		NET_ADD_STATS_BH(sock_net(sk),
		LINUX_MIB_BUSYPOLLRXPACKETS, rc);
		cpu_relax();

		} while (!nonblock && skb_queue_empty(&sk->sk_receive_queue) &&
		!need_resched() && !busy_loop_timeout(end_time));

		rc = !skb_queue_empty(&sk->sk_receive_queue);
		out:
		rcu_read_unlock_bh();
		rcu_read_unlock();
		return rc;
		}
		EXPORT_SYMBOL(sk_busy_loop);

Admin message