Commit 29decd21 authored Mar 25, 2020 by Tomi Valkeinen Committed by Mauro Carvalho Chehab Apr 14, 2020

media: ti-vpe: cal: fix use of wrong macro



i913_errata() sets a bit to 1 in PHY_REG10, but for some reason uses
CAL_CSI2_PHY_REG0_HSCLOCKCONFIG_DISABLE for the bit value. The value of
that macro is 1, so it works, but is still wrong.

Fix this to 1.

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Benoit Parrot <bparrot@ti.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

parent 52864957

drivers/media/platform/ti-vpe/cal.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -645,8 +645,7 @@ static void i913_errata(struct cal_dev *dev, unsigned int port)
		{
		u32 reg10 = reg_read(dev->cc[port], CAL_CSI2_PHY_REG10);

		set_field(&reg10, CAL_CSI2_PHY_REG0_HSCLOCKCONFIG_DISABLE,
		CAL_CSI2_PHY_REG10_I933_LDO_DISABLE_MASK);
		set_field(&reg10, 1, CAL_CSI2_PHY_REG10_I933_LDO_DISABLE_MASK);

		cal_dbg(1, dev, "CSI2_%d_REG10 = 0x%08x\n", port, reg10);
		reg_write(dev->cc[port], CAL_CSI2_PHY_REG10, reg10);

Admin message