Commit 29dd0dae authored Nov 07, 2007 by Paul Mundt

rtc: sh-rtc: Handle rtc_device_register() failure properly.



Currently if rtc_device_register() fails we have an IS_ERR() on
the wrong pointer, which causes this to always be skipped. Fix
this up to actually check the right pointer. The return value
was always correct, even though the check was wrong.

Signed-off-by: Paul Mundt <lethal@linux-sh.org>

parent 9c88b6ba

drivers/rtc/rtc-sh.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -588,7 +588,7 @@ static int __devinit sh_rtc_probe(struct platform_device *pdev)

		rtc->rtc_dev = rtc_device_register("sh", &pdev->dev,
		&sh_rtc_ops, THIS_MODULE);
		if (IS_ERR(rtc)) {
		if (IS_ERR(rtc->rtc_dev)) {
		ret = PTR_ERR(rtc->rtc_dev);
		goto err_badmap;
		}

Admin message