cifs: remove set but not used variable 'server' (29cbfa1b) · Commits · 戴 / test

Fixes gcc '-Wunused-but-set-variable' warning: fs/cifs/smb2pdu.c: In function 'smb311_posix_mkdir': fs/cifs/smb2pdu.c:2040:26: warning: variable 'server' set but not used [-Wunused-but-set-variable] fs/cifs/smb2pdu.c: In function 'build_qfs_info_req': fs/cifs/smb2pdu.c:4067:26: warning: variable 'server' set but not used [-Wunused-but-set-variable] The first 'server' never used since commit ("smb3: Fix mode on mkdir on smb311 mounts") And the second not used since commit ("cifs: remove header_preamble_size where it is always 0") Signed-off-by:

YueHaibing <yuehaibing@huawei.com> Signed-off-by:

Steve French <stfrench@microsoft.com>

fs/cifs/smb2pdu.c

+1 −7

Original line number	Diff line number	Diff line
		@@ -1955,7 +1955,6 @@ int smb311_posix_mkdir(const unsigned int xid, struct inode *inode,
		struct smb_rqst rqst;
		struct smb2_create_req *req;
		struct smb2_create_rsp *rsp = NULL;
		struct TCP_Server_Info *server;
		struct cifs_ses *ses = tcon->ses;
		struct kvec iov[3]; /* make sure at least one for each open context */
		struct kvec rsp_iov = {NULL, 0};
		@@ -1978,9 +1977,7 @@ int smb311_posix_mkdir(const unsigned int xid, struct inode *inode,
		if (!utf16_path)
		return -ENOMEM;

		if (ses && (ses->server))
		server = ses->server;
		else {
		if (!ses \|\| !(ses->server)) {
		rc = -EIO;
		goto err_free_path;
		}
		@@ -3982,7 +3979,6 @@ static int
		build_qfs_info_req(struct kvec iov, struct cifs_tcon tcon, int level,
		int outbuf_len, u64 persistent_fid, u64 volatile_fid)
		{
		struct TCP_Server_Info *server;
		int rc;
		struct smb2_query_info_req *req;
		unsigned int total_len;
		@@ -3992,8 +3988,6 @@ build_qfs_info_req(struct kvec iov, struct cifs_tcon tcon, int level,
		if ((tcon->ses == NULL) \|\| (tcon->ses->server == NULL))
		return -EIO;

		server = tcon->ses->server;

		rc = smb2_plain_req_init(SMB2_QUERY_INFO, tcon, (void **) &req,
		&total_len);
		if (rc)

Admin message