Commit 29c2680f authored by Harald Freudenberger's avatar Harald Freudenberger Committed by Heiko Carstens
Browse files

s390/ap: fix ap devices reference counting 



With the last rework of the AP bus scan function one get_device() is
missing causing the reference counter to be one instance too
low. Together with binding/unbinding device drivers to an ap device it
may end up in an segfault because the ap device is freed but a device
driver still assumes it's pointer to the ap device is valid:

Unable to handle kernel pointer dereference in virtual kernel address space
Failing address: 6b6b6b6b6b6b6000 TEID: 6b6b6b6b6b6b6803
Fault in home space mode while using kernel ASCE.
Krnl PSW : 0404e00180000000 000000001472f3b6 (klist_next+0x7e/0x180)
           R:0 T:1 IO:0 EX:0 Key:0 M:1 W:0 P:0 AS:3 CC:2 PM:0 RI:0 EA:3
Call Trace:
 [<000000001472f3b6>] klist_next+0x7e/0x180
([<000000001472f36a>] klist_next+0x32/0x180)
 [<00000000147c14de>] bus_for_each_dev+0x66/0xb8
 [<0000000014aab0d4>] ap_scan_adapter+0xcc/0x6c0
 [<0000000014aab74a>] ap_scan_bus+0x82/0x140
 [<0000000013f3b654>] process_one_work+0x27c/0x478
 [<0000000013f3b8b6>] worker_thread+0x66/0x368
 [<0000000013f44e32>] kthread+0x17a/0x1a0
 [<0000000014af23e4>] ret_from_fork+0x24/0x2c
Kernel panic - not syncing: Fatal exception: panic_on_oops

Fixed by adjusting the reference count with get_device() on the right
place. Also now the device drivers don't need to adjust the ap
device's reference counting any more. This is now done in the ap bus
probe and remove functions.

Reported-by: default avatarMarc Hartmayer <mhartmay@linux.ibm.com>
Fixes: 4f2fcccd ("s390/ap: add card/queue deconfig state")
Signed-off-by: default avatarHarald Freudenberger <freude@linux.ibm.com>
Signed-off-by: default avatarHeiko Carstens <hca@linux.ibm.com>
parent 3cea11cd

drivers/s390/crypto/ap_bus.c

+12 −2
Original line number Diff line number Diff line
@@ -680,7 +680,10 @@ static int ap_device_probe(struct device *dev) 
{

	struct ap_device *ap_dev = to_ap_dev(dev);

	struct ap_driver *ap_drv = to_ap_drv(dev->driver);

	int card, queue, devres, drvres, rc;

	int card, queue, devres, drvres, rc = -ENODEV;



	if (!get_device(dev))

		return rc;



	if (is_queue_dev(dev)) {

		/*
@@ -697,7 +700,7 @@ static int ap_device_probe(struct device *dev) 
		mutex_unlock(&ap_perms_mutex);

		drvres = ap_drv->flags & AP_DRIVER_FLAG_DEFAULT;

		if (!!devres != !!drvres)

			return -ENODEV;

			goto out;

	}



	/* Add queue/card to list of active queues/cards */
@@ -718,6 +721,9 @@ static int ap_device_probe(struct device *dev) 
		ap_dev->drv = NULL;

	}



out:

	if (rc)

		put_device(dev);

	return rc;

}
@@ -744,6 +750,8 @@ static int ap_device_remove(struct device *dev) 
		hash_del(&to_ap_queue(dev)->hnode);

	spin_unlock_bh(&ap_queues_lock);



	put_device(dev);



	return 0;

}
@@ -1371,6 +1379,8 @@ static inline void ap_scan_domains(struct ap_card *ac) 
					    __func__, ac->id, dom);

				goto put_dev_and_continue;

			}

			/* get it and thus adjust reference counter */

			get_device(dev);

			if (decfg)

				AP_DBF_INFO("%s(%d,%d) new (decfg) queue device created\n",

					    __func__, ac->id, dom);

drivers/s390/crypto/zcrypt_card.c

+8 −5
Original line number Diff line number Diff line
@@ -157,11 +157,6 @@ int zcrypt_card_register(struct zcrypt_card *zc) 
{

	int rc;



	rc = sysfs_create_group(&zc->card->ap_dev.device.kobj,

				&zcrypt_card_attr_group);

	if (rc)

		return rc;



	spin_lock(&zcrypt_list_lock);

	list_add_tail(&zc->list, &zcrypt_card_list);

	spin_unlock(&zcrypt_list_lock);
@@ -170,6 +165,14 @@ int zcrypt_card_register(struct zcrypt_card *zc) 


	ZCRYPT_DBF(DBF_INFO, "card=%02x register online=1\n", zc->card->id);



	rc = sysfs_create_group(&zc->card->ap_dev.device.kobj,

				&zcrypt_card_attr_group);

	if (rc) {

		spin_lock(&zcrypt_list_lock);

		list_del_init(&zc->list);

		spin_unlock(&zcrypt_list_lock);

	}



	return rc;

}

EXPORT_SYMBOL(zcrypt_card_register);

drivers/s390/crypto/zcrypt_queue.c

+1 −5
Original line number Diff line number Diff line
@@ -180,7 +180,6 @@ int zcrypt_queue_register(struct zcrypt_queue *zq) 
				&zcrypt_queue_attr_group);

	if (rc)

		goto out;

	get_device(&zq->queue->ap_dev.device);



	if (zq->ops->rng) {

		rc = zcrypt_rng_device_add();
@@ -192,7 +191,6 @@ int zcrypt_queue_register(struct zcrypt_queue *zq) 
out_unregister:

	sysfs_remove_group(&zq->queue->ap_dev.device.kobj,

			   &zcrypt_queue_attr_group);

	put_device(&zq->queue->ap_dev.device);

out:

	spin_lock(&zcrypt_list_lock);

	list_del_init(&zq->list);
@@ -220,12 +218,10 @@ void zcrypt_queue_unregister(struct zcrypt_queue *zq) 
	list_del_init(&zq->list);

	zcrypt_device_count--;

	spin_unlock(&zcrypt_list_lock);

	zcrypt_card_put(zc);

	if (zq->ops->rng)

		zcrypt_rng_device_remove();

	sysfs_remove_group(&zq->queue->ap_dev.device.kobj,

			   &zcrypt_queue_attr_group);

	put_device(&zq->queue->ap_dev.device);

	zcrypt_queue_put(zq);

	zcrypt_card_put(zc);

}

EXPORT_SYMBOL(zcrypt_queue_unregister);

CRA Git | Maintained and supported by SUSTech CRA and CCSE