Commit 29bdc883 authored by Vladimir Sokolovsky's avatar Vladimir Sokolovsky Committed by Roland Dreier
Browse files

IB/mlx4: Fix up fast register page list format 



Byte swap the addresses in the page list for fast register work requests
to big endian to match what the HCA expectx.  Also, the addresses must
have the "present" bit set so that the HCA knows it can access them.
Otherwise the HCA will fault the first time it accesses the memory
region.

Signed-off-by: default avatarVladimir Sokolovsky <vlad@mellanox.co.il>
Signed-off-by: default avatarRoland Dreier <rolandd@cisco.com>
parent c9257433

drivers/infiniband/hw/mlx4/qp.c

+6 −0
Original line number Diff line number Diff line
@@ -1342,6 +1342,12 @@ static __be32 convert_access(int acc) 
static void set_fmr_seg(struct mlx4_wqe_fmr_seg *fseg, struct ib_send_wr *wr)

{

	struct mlx4_ib_fast_reg_page_list *mfrpl = to_mfrpl(wr->wr.fast_reg.page_list);

	int i;



	for (i = 0; i < wr->wr.fast_reg.page_list_len; ++i)

		wr->wr.fast_reg.page_list->page_list[i] =

			cpu_to_be64(wr->wr.fast_reg.page_list->page_list[i] |

				    MLX4_MTT_FLAG_PRESENT);



	fseg->flags		= convert_access(wr->wr.fast_reg.access_flags);

	fseg->mem_key		= cpu_to_be32(wr->wr.fast_reg.rkey);

drivers/net/mlx4/mr.c

+0 −2
Original line number Diff line number Diff line
@@ -71,8 +71,6 @@ struct mlx4_mpt_entry { 
#define MLX4_MPT_PD_FLAG_RAE	    (1 << 28)

#define MLX4_MPT_PD_FLAG_EN_INV	    (3 << 24)



#define MLX4_MTT_FLAG_PRESENT		1



#define MLX4_MPT_STATUS_SW		0xF0

#define MLX4_MPT_STATUS_HW		0x00

include/linux/mlx4/device.h

+4 −0
Original line number Diff line number Diff line
@@ -141,6 +141,10 @@ enum { 
	MLX4_STAT_RATE_OFFSET	= 5

};



enum {

	MLX4_MTT_FLAG_PRESENT		= 1

};



static inline u64 mlx4_fw_ver(u64 major, u64 minor, u64 subminor)

{

	return (major << 32) | (minor << 16) | subminor;

CRA Git | Maintained and supported by SUSTech CRA and CCSE