Commit 29b9e148 authored by Jason Gerecke's avatar Jason Gerecke Committed by Jiri Kosina
Browse files

HID: wacom: Replace touch_max fixup code with static touch_max definitions 



Detecting the number of supported touches for a particular device used
to be tricky, both because early forms of the driver didn't have a very
good HID parser and because early hardware didn't always advertise the
actual number. At the time, we added a block of code which would ensure
that touch_max would always be equal to at least 1 on any touch device,
and relied on setting touch_max to e.g. 2 only for the multitouch-capable
exceptions.

The common case has since flipped, and the driver and descriptors can
reliably detect the number of touches supported by modern sensors.
Because of this, it makes sense to remove the fixup code and instead
place static declarations of "touch_max = 1" for these old devices. It
isn't entirely clear if all 2-finger devices actually report a maximum
number of touches so we leave these declarations still in place.

For the eagle-eyed, the "> BAMBOO_PT" condition was originally equivalent
to ">= TABLETPC", which is what the intent was. This commit doesn't have
to consider the types introduced in the interim since they shouldn't be
affected, hence why only the tablet PC definitions have been modified.

Signed-off-by: default avatarJason Gerecke <jason.gerecke@wacom.com>
Reviewed-by: default avatarPing Cheng <ping.cheng@wacom.com>
Signed-off-by: default avatarJiri Kosina <jkosina@suse.cz>
parent 81e97f01

drivers/hid/wacom_sys.c

+0 −10
Original line number Diff line number Diff line
@@ -361,16 +361,6 @@ static void wacom_usage_mapping(struct hid_device *hdev, 
	else

		return;



	/*

	 * Bamboo models do not support HID_DG_CONTACTMAX.

	 * And, Bamboo Pen only descriptor contains touch.

	 */

	if (features->type > BAMBOO_PT) {

		/* ISDv4 touch devices at least supports one touch point */

		if (finger && !features->touch_max)

			features->touch_max = 1;

	}



	/*

	 * ISDv4 devices which predate HID's adoption of the

	 * HID_DG_BARELSWITCH2 usage use 0x000D0000 in its

drivers/hid/wacom_wac.c

+10 −10
Original line number Diff line number Diff line
@@ -4351,19 +4351,19 @@ static const struct wacom_features wacom_features_0x5E = 
	  .check_for_hid_type = true, .hid_type = HID_TYPE_USBNONE };

static const struct wacom_features wacom_features_0x90 =

	{ "Wacom ISDv4 90", 26202, 16325, 255, 0,

	  TABLETPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES };

	  TABLETPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES }; /* Pen-only */

static const struct wacom_features wacom_features_0x93 =

	{ "Wacom ISDv4 93", 26202, 16325, 255, 0,

	  TABLETPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES };

	  TABLETPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES, .touch_max = 1 };

static const struct wacom_features wacom_features_0x97 =

	{ "Wacom ISDv4 97", 26202, 16325, 511, 0,

	  TABLETPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES };

	  TABLETPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES }; /* Pen-only */

static const struct wacom_features wacom_features_0x9A =

	{ "Wacom ISDv4 9A", 26202, 16325, 255, 0,

	  TABLETPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES };

	  TABLETPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES, .touch_max = 1 };

static const struct wacom_features wacom_features_0x9F =

	{ "Wacom ISDv4 9F", 26202, 16325, 255, 0,

	  TABLETPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES };

	  TABLETPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES, .touch_max = 1 };

static const struct wacom_features wacom_features_0xE2 =

	{ "Wacom ISDv4 E2", 26202, 16325, 255, 0,

	  TABLETPC2FG, WACOM_INTUOS_RES, WACOM_INTUOS_RES, .touch_max = 2 };
@@ -4378,13 +4378,13 @@ static const struct wacom_features wacom_features_0xE6 = 
	  TABLETPC2FG, WACOM_INTUOS_RES, WACOM_INTUOS_RES, .touch_max = 2 };

static const struct wacom_features wacom_features_0xEC =

	{ "Wacom ISDv4 EC", 25710, 14500, 255, 0,

	  TABLETPC,    WACOM_INTUOS_RES, WACOM_INTUOS_RES };

	  TABLETPC,    WACOM_INTUOS_RES, WACOM_INTUOS_RES }; /* Pen-only */

static const struct wacom_features wacom_features_0xED =

	{ "Wacom ISDv4 ED", 26202, 16325, 255, 0,

	  TABLETPCE, WACOM_INTUOS_RES, WACOM_INTUOS_RES };

	  TABLETPCE, WACOM_INTUOS_RES, WACOM_INTUOS_RES, .touch_max = 1 };

static const struct wacom_features wacom_features_0xEF =

	{ "Wacom ISDv4 EF", 26202, 16325, 255, 0,

	  TABLETPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES };

	  TABLETPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES }; /* Pen-only */

static const struct wacom_features wacom_features_0x100 =

	{ "Wacom ISDv4 100", 26202, 16325, 255, 0,

	  MTTPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES };
@@ -4402,10 +4402,10 @@ static const struct wacom_features wacom_features_0x10F = 
	  MTTPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES };

static const struct wacom_features wacom_features_0x116 =

	{ "Wacom ISDv4 116", 26202, 16325, 255, 0,

	  TABLETPCE, WACOM_INTUOS_RES, WACOM_INTUOS_RES };

	  TABLETPCE, WACOM_INTUOS_RES, WACOM_INTUOS_RES, .touch_max = 1 };

static const struct wacom_features wacom_features_0x12C =

	{ "Wacom ISDv4 12C", 27848, 15752, 2047, 0,

	  TABLETPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES };

	  TABLETPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES }; /* Pen-only */

static const struct wacom_features wacom_features_0x4001 =

	{ "Wacom ISDv4 4001", 26202, 16325, 255, 0,

	  MTTPC, WACOM_INTUOS_RES, WACOM_INTUOS_RES };

CRA Git | Maintained and supported by SUSTech CRA and CCSE