Commit 29b74cb7 authored May 13, 2020 by Wei Yongjun Committed by David S. Miller May 13, 2020

s390/ism: fix error return code in ism_probe()



Fix to return negative error code -ENOMEM from the smcd_alloc_dev()
error handling case instead of 0, as done elsewhere in this function.

Fixes: 684b89bc ("s390/ism: add device driver for internal shared memory")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Ursula Braun <ubraun@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent eead1c2e

drivers/s390/net/ism_drv.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -521,8 +521,10 @@ static int ism_probe(struct pci_dev pdev, const struct pci_device_id id)

		ism->smcd = smcd_alloc_dev(&pdev->dev, dev_name(&pdev->dev), &ism_ops,
		ISM_NR_DMBS);
		if (!ism->smcd)
		if (!ism->smcd) {
		ret = -ENOMEM;
		goto err_resource;
		}

		ism->smcd->priv = ism;
		ret = ism_dev_init(ism);

Admin message