staging: comedi: ni_mio_common: make internal functions static (29aba763) · Commits · 戴 / test

The functions ni_release_gpct_mite_channel() and ni_prime_channelgain_list() are only referenced in this file. Make it static. The function ni_release_gpct_mite_channel() is also only called when PCIDMA is enabled. Move the #ifdef to quite a sparse warning about the function not being used. Signed-off-by:

H Hartley Sweeten <hsweeten@visionengravers.com> Cc: Ian Abbott <abbotti@mev.co.uk> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/comedi/drivers/ni_mio_common.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -644,10 +644,10 @@ static void ni_release_ao_mite_channel(struct comedi_device *dev)
		#endif /* PCIDMA */
		}

		void ni_release_gpct_mite_channel(struct comedi_device *dev,
		#ifdef PCIDMA
		static void ni_release_gpct_mite_channel(struct comedi_device *dev,
		unsigned gpct_index)
		{
		#ifdef PCIDMA
		unsigned long flags;

		BUG_ON(gpct_index >= NUM_GPCT);
		@@ -663,8 +663,8 @@ void ni_release_gpct_mite_channel(struct comedi_device *dev,
		mite_release_channel(mite_chan);
		}
		spin_unlock_irqrestore(&devpriv->mite_channel_lock, flags);
		#endif /* PCIDMA */
		}
		#endif /* PCIDMA */

		static void ni_release_cdo_mite_channel(struct comedi_device *dev)
		{
		@@ -1881,7 +1881,7 @@ static int ni_ai_insn_read(struct comedi_device *dev,
		return insn->n;
		}

		void ni_prime_channelgain_list(struct comedi_device *dev)
		static void ni_prime_channelgain_list(struct comedi_device *dev)
		{
		int i;
		devpriv->stc_writew(dev, AI_CONVERT_Pulse, AI_Command_1_Register);

Admin message