ide/libata: fix ata_id_is_cfa() (take 4) (2999b58b) · Commits · 戴 / test

When checking for the CFA feature set support, ata_id_is_cfa() tests bit 2 in word 82 of the identify data instead the word 83; it also checks the ATA/PI version support in the word 80 (which the CompactFlash specifications have as reserved), this having no slightest chance to work on the modern CF cards that don't have 0x848A in the word 0... Signed-off-by:

Sergei Shtylyov <sshtylyov@ru.mvista.com> Signed-off-by:

Jeff Garzik <jgarzik@redhat.com>

include/linux/ata.h

+10 −5

Original line number	Diff line number	Diff line
		@@ -731,12 +731,17 @@ static inline int ata_id_current_chs_valid(const u16 *id)

		static inline int ata_id_is_cfa(const u16 *id)
		{
		if (id[ATA_ID_CONFIG] == 0x848A) /* Standard CF */
		if (id[ATA_ID_CONFIG] == 0x848A) /* Traditional CF */
		return 1;
		/* Could be CF hiding as standard ATA */
		if (ata_id_major_version(id) >= 3 &&
		id[ATA_ID_COMMAND_SET_1] != 0xFFFF &&
		(id[ATA_ID_COMMAND_SET_1] & (1 << 2)))
		/*
		* CF specs don't require specific value in the word 0 anymore and yet
		* they forbid to report the ATA version in the word 80 and require the
		* CFA feature set support to be indicated in the word 83 in this case.
		* Unfortunately, some cards only follow either of this requirements,
		* and while those that don't indicate CFA feature support need some
		* sort of quirk list, it seems impractical for the ones that do...
		*/
		if ((id[ATA_ID_COMMAND_SET_2] & 0xC004) == 0x4004)
		return 1;
		return 0;
		}

Admin message