Commit 29838144 authored Sep 29, 2020 by Dan Carpenter Committed by Greg Kroah-Hartman Oct 01, 2020

staging: rtl8712: Fix enqueue_reorder_recvframe()

The logic of this function was accidentally broken by a checkpatch
inspired cleanup. I've modified the code to restore the original
behavior and also make checkpatch happy.

Fixes: 98fe05e2 ("staging: rtl8712: Remove unnecesary else after return statement.")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20200929103548.GA493135@mwanda

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent e6ac17de

drivers/staging/rtl8712/rtl8712_recv.c

+6 −3

Original line number	Diff line number	Diff line
		@@ -476,10 +476,13 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl,
		while (!end_of_queue_search(phead, plist)) {
		pnextrframe = container_of(plist, union recv_frame, u.list);
		pnextattrib = &pnextrframe->u.hdr.attrib;

		if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num))
		return false;

		if (SN_LESS(pnextattrib->seq_num, pattrib->seq_num))
		plist = plist->next;
		else if (SN_EQUAL(pnextattrib->seq_num, pattrib->seq_num))
		return false;
		else
		break;
		}
		list_del_init(&(prframe->u.hdr.list));