Commit 296a37fd authored Mar 13, 2020 by Takashi Iwai

ALSA: pcm: Fix superfluous snprintf() usage

show_pcm_class() returns obviously a short string that can't overflow
PAGE_SIZE.  And even if it were to overflow, using snprintf() there is
just wrong, as it doesn't return the correct size.
So simplify with sprintf() instead.

Link: https://lore.kernel.org/r/20200313130223.8908-1-tiwai@suse.de


Signed-off-by: Takashi Iwai <tiwai@suse.de>

parent 3db1b00f

sound/core/pcm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1019,7 +1019,7 @@ static ssize_t show_pcm_class(struct device *dev,
		str = "none";
		else
		str = strs[pcm->dev_class];
		return snprintf(buf, PAGE_SIZE, "%s\n", str);
		return sprintf(buf, "%s\n", str);
		}

		static DEVICE_ATTR(pcm_class, 0444, show_pcm_class, NULL);

Admin message