Commit 295a1730 authored Oct 15, 2020 by Bartosz Golaszewski Committed by Linus Torvalds Oct 16, 2020

mm/util.c: update the kerneldoc for kstrdup_const()



Memory allocated with kstrdup_const() must not be passed to regular
krealloc() as it is not aware of the possibility of the chunk residing in
.rodata.  Since there are no potential users of krealloc_const() at the
moment, let's just update the doc to make it explicit.

Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20200817173927.23389-1-brgl@bgdev.pl


Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 40610076

mm/util.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -69,7 +69,8 @@ EXPORT_SYMBOL(kstrdup);
		* @s: the string to duplicate
		* @gfp: the GFP mask used in the kmalloc() call when allocating memory
		*
		* Note: Strings allocated by kstrdup_const should be freed by kfree_const.
		* Note: Strings allocated by kstrdup_const should be freed by kfree_const and
		* must not be passed to krealloc().
		*
		* Return: source string if it is in .rodata section otherwise
		* fallback to kstrdup.

Admin message