Commit 2956b5d9 authored by Mika Westerberg's avatar Mika Westerberg Committed by Linus Walleij
Browse files

pinctrl / gpio: Introduce .set_config() callback for GPIO chips 



Currently we already have two pin configuration related callbacks
available for GPIO chips .set_single_ended() and .set_debounce(). In
future we expect to have even more, which does not scale well if we need
to add yet another callback to the GPIO chip structure for each possible
configuration parameter.

Better solution is to reuse what we already have available in the
generic pinconf.

To support this, we introduce a new .set_config() callback for GPIO
chips. The callback takes a single packed pin configuration value as
parameter. This can then be extended easily beyond what is currently
supported by just adding new types to the generic pinconf enum.

If the GPIO driver is backed up by a pinctrl driver the GPIO driver can
just assign gpiochip_generic_config() (introduced in this patch) to
.set_config and that will take care configuration requests are directed
to the pinctrl driver.

We then convert the existing drivers over .set_config() and finally
remove the .set_single_ended() and .set_debounce() callbacks.

Suggested-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Signed-off-by: default avatarMika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 15381bc7

Documentation/gpio/driver.txt

+5 −4
Original line number Diff line number Diff line
@@ -146,10 +146,11 @@ a pull-up resistor is needed on the outgoing rail to complete the circuit, and 
in the second case, a pull-down resistor is needed on the rail.



Hardware that supports open drain or open source or both, can implement a

special callback in the gpio_chip: .set_single_ended() that takes an enum flag

telling whether to configure the line as open drain, open source or push-pull.

This will happen in response to the GPIO_OPEN_DRAIN or GPIO_OPEN_SOURCE flag

set in the machine file, or coming from other hardware descriptions.

special callback in the gpio_chip: .set_config() that takes a generic

pinconf packed value telling whether to configure the line as open drain,

open source or push-pull. This will happen in response to the

GPIO_OPEN_DRAIN or GPIO_OPEN_SOURCE flag set in the machine file, or coming

from other hardware descriptions.



If this state can not be configured in hardware, i.e. if the GPIO hardware does

not support open drain/open source in hardware, the GPIO library will instead

drivers/gpio/gpio-bcm-kona.c

+13 −1
Original line number Diff line number Diff line
@@ -308,6 +308,18 @@ static int bcm_kona_gpio_set_debounce(struct gpio_chip *chip, unsigned gpio, 
	return 0;

}



static int bcm_kona_gpio_set_config(struct gpio_chip *chip, unsigned gpio,

				    unsigned long config)

{

	u32 debounce;



	if (pinconf_to_config_param(config) != PIN_CONFIG_INPUT_DEBOUNCE)

		return -ENOTSUPP;



	debounce = pinconf_to_config_argument(config);

	return bcm_kona_gpio_set_debounce(chip, gpio, debounce);

}



static const struct gpio_chip template_chip = {

	.label = "bcm-kona-gpio",

	.owner = THIS_MODULE,
@@ -318,7 +330,7 @@ static const struct gpio_chip template_chip = { 
	.get = bcm_kona_gpio_get,

	.direction_output = bcm_kona_gpio_direction_output,

	.set = bcm_kona_gpio_set,

	.set_debounce = bcm_kona_gpio_set_debounce,

	.set_config = bcm_kona_gpio_set_config,

	.to_irq = bcm_kona_gpio_to_irq,

	.base = 0,

};

drivers/gpio/gpio-dln2.c

+8 −4
Original line number Diff line number Diff line
@@ -272,12 +272,16 @@ static int dln2_gpio_direction_output(struct gpio_chip *chip, unsigned offset, 
	return dln2_gpio_set_direction(chip, offset, DLN2_GPIO_DIRECTION_OUT);

}



static int dln2_gpio_set_debounce(struct gpio_chip *chip, unsigned offset,

				  unsigned debounce)

static int dln2_gpio_set_config(struct gpio_chip *chip, unsigned offset,

				unsigned long config)

{

	struct dln2_gpio *dln2 = gpiochip_get_data(chip);

	__le32 duration = cpu_to_le32(debounce);

	__le32 duration;



	if (pinconf_to_config_param(config) != PIN_CONFIG_INPUT_DEBOUNCE)

		return -ENOTSUPP;



	duration = cpu_to_le32(pinconf_to_config_argument(config));

	return dln2_transfer_tx(dln2->pdev, DLN2_GPIO_SET_DEBOUNCE,

				&duration, sizeof(duration));

}
@@ -474,7 +478,7 @@ static int dln2_gpio_probe(struct platform_device *pdev) 
	dln2->gpio.get_direction = dln2_gpio_get_direction;

	dln2->gpio.direction_input = dln2_gpio_direction_input;

	dln2->gpio.direction_output = dln2_gpio_direction_output;

	dln2->gpio.set_debounce = dln2_gpio_set_debounce;

	dln2->gpio.set_config = dln2_gpio_set_config;



	platform_set_drvdata(pdev, dln2);

drivers/gpio/gpio-dwapb.c

+13 −1
Original line number Diff line number Diff line
@@ -279,6 +279,18 @@ static int dwapb_gpio_set_debounce(struct gpio_chip *gc, 
	return 0;

}



static int dwapb_gpio_set_config(struct gpio_chip *gc, unsigned offset,

				 unsigned long config)

{

	u32 debounce;



	if (pinconf_to_config_param(config) != PIN_CONFIG_INPUT_DEBOUNCE)

		return -ENOTSUPP;



	debounce = pinconf_to_config_argument(config);

	return dwapb_gpio_set_debounce(gc, offset, debounce);

}



static irqreturn_t dwapb_irq_handler_mfd(int irq, void *dev_id)

{

	u32 worked;
@@ -426,7 +438,7 @@ static int dwapb_gpio_add_port(struct dwapb_gpio *gpio, 


	/* Only port A support debounce */

	if (pp->idx == 0)

		port->gc.set_debounce = dwapb_gpio_set_debounce;

		port->gc.set_config = dwapb_gpio_set_config;



	if (pp->irq)

		dwapb_configure_irqs(gpio, port, pp);

drivers/gpio/gpio-ep93xx.c

+8 −3
Original line number Diff line number Diff line
@@ -291,15 +291,20 @@ static struct ep93xx_gpio_bank ep93xx_gpio_banks[] = { 
	EP93XX_GPIO_BANK("H", 0x40, 0x44, 56, false),

};



static int ep93xx_gpio_set_debounce(struct gpio_chip *chip,

				    unsigned offset, unsigned debounce)

static int ep93xx_gpio_set_config(struct gpio_chip *chip, unsigned offset,

				  unsigned long config)

{

	int gpio = chip->base + offset;

	int irq = gpio_to_irq(gpio);

	u32 debounce;



	if (pinconf_to_config_param(config) != PIN_CONFIG_INPUT_DEBOUNCE)

		return -ENOTSUPP;



	if (irq < 0)

		return -EINVAL;



	debounce = pinconf_to_config_argument(config);

	ep93xx_gpio_int_debounce(irq, debounce ? true : false);



	return 0;
@@ -335,7 +340,7 @@ static int ep93xx_gpio_add_bank(struct gpio_chip *gc, struct device *dev, 
	gc->base = bank->base;



	if (bank->has_debounce) {

		gc->set_debounce = ep93xx_gpio_set_debounce;

		gc->set_config = ep93xx_gpio_set_config;

		gc->to_irq = ep93xx_gpio_to_irq;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE