Commit 294acf1c authored Mar 07, 2017 by Paolo Abeni Committed by David S. Miller Mar 09, 2017

net/tunnel: set inner protocol in network gro hooks



The gso code of several tunnels type (gre and udp tunnels)
takes for granted that the skb->inner_protocol is properly
initialized and drops the packet elsewhere.

On the forwarding path no one is initializing such field,
so gro encapsulated packets are dropped on forward.

Since commit 38720352 ("gre: Use inner_proto to obtain
inner header protocol"), this can be reproduced when the
encapsulated packets use gre as the tunneling protocol.

The issue happens also with vxlan and geneve tunnels since
commit 8bce6d7d ("udp: Generalize skb_udp_segment"), if the
forwarding host's ingress nic has h/w offload for such tunnel
and a vxlan/geneve device is configured on top of it, regardless
of the configured peer address and vni.

To address the issue, this change initialize the inner_protocol
field for encapsulated packets in both ipv4 and ipv6 gro complete
callbacks.

Fixes: 38720352 ("gre: Use inner_proto to obtain inner header protocol")
Fixes: 8bce6d7d ("udp: Generalize skb_udp_segment")
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Acked-by: Alexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8aad6f14

net/ipv4/af_inet.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1487,8 +1487,10 @@ int inet_gro_complete(struct sk_buff *skb, int nhoff)
		int proto = iph->protocol;
		int err = -ENOSYS;

		if (skb->encapsulation)
		if (skb->encapsulation) {
		skb_set_inner_protocol(skb, cpu_to_be16(ETH_P_IP));
		skb_set_inner_network_header(skb, nhoff);
		}

		csum_replace2(&iph->check, iph->tot_len, newlen);
		iph->tot_len = newlen;

net/ipv6/ip6_offload.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -294,8 +294,10 @@ static int ipv6_gro_complete(struct sk_buff *skb, int nhoff)
		struct ipv6hdr iph = (struct ipv6hdr )(skb->data + nhoff);
		int err = -ENOSYS;

		if (skb->encapsulation)
		if (skb->encapsulation) {
		skb_set_inner_protocol(skb, cpu_to_be16(ETH_P_IPV6));
		skb_set_inner_network_header(skb, nhoff);
		}

		iph->payload_len = htons(skb->len - nhoff - sizeof(*iph));

Admin message