Commit 2933954b authored Jul 15, 2019 by Rafael J. Wysocki

PM: sleep: Fix possible overflow in pm_system_cancel_wakeup()



It is not actually guaranteed that pm_abort_suspend will be
nonzero when pm_system_cancel_wakeup() is called which may lead to
subtle issues, so make it use atomic_dec_if_positive() instead of
atomic_dec() for the safety sake.

Fixes: 33e4f80e ("ACPI / PM: Ignore spurious SCI wakeups from suspend-to-idle")
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Acked-by: Thomas Gleixner <tglx@linutronix.de>

parent 9089f16e

drivers/base/power/wakeup.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -859,7 +859,7 @@ EXPORT_SYMBOL_GPL(pm_system_wakeup);

		void pm_system_cancel_wakeup(void)
		{
		atomic_dec(&pm_abort_suspend);
		atomic_dec_if_positive(&pm_abort_suspend);
		}

		void pm_wakeup_clear(bool reset)

Admin message