Commit 292fed1f authored Apr 27, 2020 by Wei Yongjun Committed by Paul Moore Apr 27, 2020

selinux: fix error return code in cond_read_list()



Fix to return negative error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.

Fixes: 60abd318 ("selinux: convert cond_list to array")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Ondrej Mosnacek <omosnace@redhat.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>

parent af15f14c

security/selinux/ss/conditional.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -429,7 +429,7 @@ int cond_read_list(struct policydb p, void fp)

		p->cond_list = kcalloc(len, sizeof(*p->cond_list), GFP_KERNEL);
		if (!p->cond_list)
		return rc;
		return -ENOMEM;

		rc = avtab_alloc(&(p->te_cond_avtab), p->te_avtab.nel);
		if (rc)

Admin message