Commit 2924bdee authored Apr 10, 2018 by Tvrtko Ursulin

drm/i915/pmu: Inspect runtime PM state more carefully while estimating RC6



While thinking about sporadic failures of perf_pmu/rc6-runtime-pm* tests
on some CI machines I have concluded that: a) the PMU readout of RC6 can
race against runtime PM transitions, and b) there are other reasons than
being runtime suspended which can cause intel_runtime_pm_get_if_in_use to
fail.

Therefore when estimating RC6 the code needs to assert we are indeed in
suspended state, and if not, the best we can do is return the last known
RC6 value.

Without this check we can calculate the estimated value based on un-
initialized or inappropriate internal state, which can result in over-
estimation, or in any case incorrect value being returned.

v2:
 * Re-arrange the code a bit to avoid second unlock and return branch.
   (Chris Wilson)

v3:
 * Insert some strategic blank lines and improve commit msg.
   (Chris Wilson)

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Fixes: 1fe699e3 ("drm/i915/pmu: Fix sleep under atomic in RC6 readout")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105010


Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.com>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20180410112704.24462-1-tvrtko.ursulin@linux.intel.com

parent 2184b3d6

drivers/gpu/drm/i915/i915_pmu.c

+27 −10

Original line number	Diff line number	Diff line
		@@ -452,6 +452,18 @@ static u64 get_rc6(struct drm_i915_private *i915)
		spin_lock_irqsave(&i915->pmu.lock, flags);
		spin_lock(&kdev->power.lock);

		/*
		* After the above branch intel_runtime_pm_get_if_in_use failed
		* to get the runtime PM reference we cannot assume we are in
		* runtime suspend since we can either: a) race with coming out
		* of it before we took the power.lock, or b) there are other
		* states than suspended which can bring us here.
		*
		* We need to double-check that we are indeed currently runtime
		* suspended and if not we cannot do better than report the last
		* known RC6 value.
		*/
		if (kdev->power.runtime_status == RPM_SUSPENDED) {
		if (!i915->pmu.sample[__I915_SAMPLE_RC6_ESTIMATED].cur)
		i915->pmu.suspended_jiffies_last =
		kdev->power.suspended_jiffies;
		@@ -460,12 +472,17 @@ static u64 get_rc6(struct drm_i915_private *i915)
		i915->pmu.suspended_jiffies_last;
		val += jiffies - kdev->power.accounting_timestamp;

		spin_unlock(&kdev->power.lock);

		val = jiffies_to_nsecs(val);
		val += i915->pmu.sample[__I915_SAMPLE_RC6].cur;

		i915->pmu.sample[__I915_SAMPLE_RC6_ESTIMATED].cur = val;
		} else if (i915->pmu.sample[__I915_SAMPLE_RC6_ESTIMATED].cur) {
		val = i915->pmu.sample[__I915_SAMPLE_RC6_ESTIMATED].cur;
		} else {
		val = i915->pmu.sample[__I915_SAMPLE_RC6].cur;
		}

		spin_unlock(&kdev->power.lock);
		spin_unlock_irqrestore(&i915->pmu.lock, flags);
		}

Admin message