Commit 28f851e6 authored Nov 17, 2020 by Yu Kuai Committed by Kevin Hilman Nov 30, 2020

soc: amlogic: canvas: add missing put_device() call in meson_canvas_get()



if of_find_device_by_node() succeed, meson_canvas_get() doesn't have
a corresponding put_device(). Thus add put_device() to fix the exception
handling for this function implementation.

Fixes: 382f8be0 ("soc: amlogic: canvas: Fix meson_canvas_get when probe failed")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
Signed-off-by: Kevin Hilman <khilman@baylibre.com>
Link: https://lore.kernel.org/r/20201117011322.522477-1-yukuai3@huawei.com

parent 4a434abc

drivers/soc/amlogic/meson-canvas.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -72,8 +72,10 @@ struct meson_canvas meson_canvas_get(struct device dev)
		* current state, this driver probe cannot return -EPROBE_DEFER
		*/
		canvas = dev_get_drvdata(&canvas_pdev->dev);
		if (!canvas)
		if (!canvas) {
		put_device(&canvas_pdev->dev);
		return ERR_PTR(-EINVAL);
		}

		return canvas;
		}

Admin message