Unverified Commit 28f7604f authored Feb 10, 2019 by Felix Fietkau Committed by Mark Brown Feb 12, 2019

spi: use gpio[d]_set_value_cansleep for setting chipselect GPIO



Sleeping is safe inside spi_transfer_one_message, and some
GPIO chips are running on slow busses (such as I2C GPIO
expanders) and need to sleep for setting values.

Signed-off-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 9b4f8421

drivers/spi/spi.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -786,9 +786,10 @@ static void spi_set_cs(struct spi_device *spi, bool enable)
		*/
		if (!(spi->mode & SPI_NO_CS)) {
		if (spi->cs_gpiod)
		gpiod_set_value(spi->cs_gpiod, !enable);
		gpiod_set_value_cansleep(spi->cs_gpiod,
		!enable);
		else
		gpio_set_value(spi->cs_gpio, !enable);
		gpio_set_value_cansleep(spi->cs_gpio, !enable);
		}
		/* Some SPI masters need both GPIO CS & slave_select */
		if ((spi->controller->flags & SPI_MASTER_GPIO_SS) &&

Admin message