Commit 28e4639a authored Sep 18, 2010 by Zachary Amsden Committed by Avi Kivity Oct 24, 2010

KVM: x86: Fix kvmclock bug



If preempted after kvmclock values are updated, but before hardware
virtualization is entered, the last tsc time as read by the guest is
never set.  It underflows the next time kvmclock is updated if there
has not yet been a successful entry / exit into hardware virt.

Fix this by simply setting last_tsc to the newly read tsc value so
that any computed nsec advance of kvmclock is nulled.

Signed-off-by: Zachary Amsden <zamsden@redhat.com>
Signed-off-by: Marcelo Tosatti <mtosatti@redhat.com>

parent 0959ffac

arch/x86/kvm/x86.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1095,6 +1095,7 @@ static int kvm_write_guest_time(struct kvm_vcpu *v)
		vcpu->hv_clock.tsc_timestamp = tsc_timestamp;
		vcpu->hv_clock.system_time = kernel_ns + v->kvm->arch.kvmclock_offset;
		vcpu->last_kernel_ns = kernel_ns;
		vcpu->last_guest_tsc = tsc_timestamp;
		vcpu->hv_clock.flags = 0;

		/*

Admin message