Commit 28d0c14b authored by Axel Lin's avatar Axel Lin Committed by Linus Walleij
Browse files

pinctrl: coh901: Fix error checking in u300_gpio_to_irq



The pointer "port" is always not NULL if gpio->port_list is not empty.

Signed-off-by: default avatarAxel Lin <axel.lin@ingics.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 175ca83c
Loading
Loading
Loading
Loading
+5 −2
Original line number Diff line number Diff line
@@ -318,13 +318,16 @@ static int u300_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
	struct u300_gpio_port *port = NULL;
	struct list_head *p;
	int retirq;
	bool found = false;

	list_for_each(p, &gpio->port_list) {
		port = list_entry(p, struct u300_gpio_port, node);
		if (port->number == portno)
		if (port->number == portno) {
			found = true;
			break;
		}
	if (port == NULL) {
	}
	if (!found) {
		dev_err(gpio->dev, "could not locate port for GPIO %d IRQ\n",
			offset);
		return -EINVAL;