Commit 28cb6f1e authored Dec 20, 2018 by John Fastabend Committed by Daniel Borkmann Dec 20, 2018

bpf: tls_sw, init TLS ULP removes BPF proto hooks

The existing code did not expect users would initialize the TLS ULP
without subsequently calling the TLS TX enabling socket option.
If the application tries to send data after the TLS ULP enable op
but before the TLS TX enable op the BPF sk_msg verdict program is
skipped. This patch resolves this by converting the ipv4 sock ops
to be calculated at init time the same way ipv6 ops are done. This
pulls in any changes to the sock ops structure that have been made
after the socket was created including the changes from adding the
socket to a sock{map|hash}.

This was discovered by running OpenSSL master branch which calls
the TLS ULP setsockopt early in TLS handshake but only enables
the TLS TX path once the handshake has completed. As a result the
datapath missed the initial handshake messages.

Fixes: 02c558b2 ("bpf: sockmap, support for msg_peek in sk_msg with redirect ingress")
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

parent 0608c69c

net/tls/tls_main.c

+12 −2

Original line number	Diff line number	Diff line
		@@ -55,6 +55,8 @@ enum {

		static struct proto *saved_tcpv6_prot;
		static DEFINE_MUTEX(tcpv6_prot_mutex);
		static struct proto *saved_tcpv4_prot;
		static DEFINE_MUTEX(tcpv4_prot_mutex);
		static LIST_HEAD(device_list);
		static DEFINE_MUTEX(device_mutex);
		static struct proto tls_prots[TLS_NUM_PROTS][TLS_NUM_CONFIG][TLS_NUM_CONFIG];
		@@ -690,6 +692,16 @@ static int tls_init(struct sock *sk)
		mutex_unlock(&tcpv6_prot_mutex);
		}

		if (ip_ver == TLSV4 &&
		unlikely(sk->sk_prot != smp_load_acquire(&saved_tcpv4_prot))) {
		mutex_lock(&tcpv4_prot_mutex);
		if (likely(sk->sk_prot != saved_tcpv4_prot)) {
		build_protos(tls_prots[TLSV4], sk->sk_prot);
		smp_store_release(&saved_tcpv4_prot, sk->sk_prot);
		}
		mutex_unlock(&tcpv4_prot_mutex);
		}

		ctx->tx_conf = TLS_BASE;
		ctx->rx_conf = TLS_BASE;
		update_sk_prot(sk, ctx);
		@@ -721,8 +733,6 @@ static struct tcp_ulp_ops tcp_tls_ulp_ops __read_mostly = {

		static int __init tls_register(void)
		{
		build_protos(tls_prots[TLSV4], &tcp_prot);

		tls_sw_proto_ops = inet_stream_ops;
		tls_sw_proto_ops.splice_read = tls_sw_splice_read;

Admin message