Commit 28bee489 authored Sep 13, 2018 by Nikolay Borisov Committed by David Sterba Oct 15, 2018

btrfs: Remove logically dead code from btrfs_orphan_cleanup



In btrfs_orphan_cleanup the final 'if (ret) goto out' cannot ever be
executed. This is due to the last assignment to 'ret' depending on the
return value of btrfs_iget. If an error other than -ENOENT is returned
then the loop is prematurely terminated by 'goto out'.  On the other
hand, if the error value is ENOENT then a subsequent if branch is
executed that always re-assigns 'ret' and in case it's an error just
terminates the loop. No functional changes.

Coverity-id: 1437392
Signed-off-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Lu Fengqi <lufq.fnst@cn.fujitsu.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 4183c52c

fs/btrfs/inode.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -3468,8 +3468,6 @@ int btrfs_orphan_cleanup(struct btrfs_root *root)

		/* this will do delete_inode and everything for us */
		iput(inode);
		if (ret)
		goto out;
		}
		/* release the path since we're done with it */
		btrfs_release_path(path);

Admin message