Commit 28b8d0c8 authored May 27, 2015 by Gobinda Charan Maji Committed by Rusty Russell May 28, 2015

sysfs: tightened sysfs permission checks

There were some inconsistency in restriction to VERIFY_OCTAL_PERMISSIONS().
Previously the test was "User perms >= group perms >= other perms". The
permission field of User, Group or Other consists of three bits. LSB is
EXECUTE permission, MSB is READ permission and the middle bit is WRITE
permission. But logically WRITE is "more privileged" than READ.

Say for example, permission value is "0430". Here User has only READ
permission whereas Group has both WRITE and EXECUTE permission.

So, the checks could be tightened and the tests are separated to
USER_READABLE >= GROUP_READABLE >= OTHER_READABLE,
USER_WRITABLE >= GROUP_WRITABLE and OTHER_WRITABLE is not permitted.

Signed-off-by: Gobinda Charan Maji <gobinda.cemk07@gmail.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

parent 4f666546

include/linux/kernel.h

+10 −8

Original line number	Diff line number	Diff line
		@@ -821,10 +821,12 @@ static inline void ftrace_dump(enum ftrace_dump_mode oops_dump_mode) { }
		#define VERIFY_OCTAL_PERMISSIONS(perms) \
		(BUILD_BUG_ON_ZERO((perms) < 0) + \
		BUILD_BUG_ON_ZERO((perms) > 0777) + \
		/* User perms >= group perms >= other perms */ \
		BUILD_BUG_ON_ZERO(((perms) >> 6) < (((perms) >> 3) & 7)) + \
		BUILD_BUG_ON_ZERO((((perms) >> 3) & 7) < ((perms) & 7)) + \
		/* Other writable? Generally considered a bad idea. */ \
		/* USER_READABLE >= GROUP_READABLE >= OTHER_READABLE */ \
		BUILD_BUG_ON_ZERO((((perms) >> 6) & 4) < (((perms) >> 3) & 4)) + \
		BUILD_BUG_ON_ZERO((((perms) >> 3) & 4) < ((perms) & 4)) + \
		/* USER_WRITABLE >= GROUP_WRITABLE */ \
		BUILD_BUG_ON_ZERO((((perms) >> 6) & 2) < (((perms) >> 3) & 2)) + \
		/* OTHER_WRITABLE? Generally considered a bad idea. */ \
		BUILD_BUG_ON_ZERO((perms) & 2) + \
		(perms))
		#endif

Admin message