Commit 28a4cac4 authored Oct 13, 2019 by Max Gurtovoy Committed by Keith Busch Oct 15, 2019

nvme-tcp: fix possible leakage during error flow



During nvme_tcp_setup_cmd_pdu error flow, one must call nvme_cleanup_cmd
since it's symmetric to nvme_setup_cmd.

Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>

parent 5812d04c

drivers/nvme/host/tcp.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2136,6 +2136,7 @@ static blk_status_t nvme_tcp_setup_cmd_pdu(struct nvme_ns *ns,

		ret = nvme_tcp_map_data(queue, rq);
		if (unlikely(ret)) {
		nvme_cleanup_cmd(rq);
		dev_err(queue->ctrl->ctrl.device,
		"Failed to map data (%d)\n", ret);
		return ret;

Admin message