Commit 289de359 authored Feb 18, 2020 by Vincent Guittot Committed by Ingo Molnar Feb 27, 2020

sched/fair: Fix statistics for find_idlest_group()



sgs->group_weight is not set while gathering statistics in
update_sg_wakeup_stats(). This means that a group can be classified as
fully busy with 0 running tasks if utilization is high enough.

This path is mainly used for fork and exec.

Fixes: 57abff06 ("sched/fair: Rework find_idlest_group()")
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Mel Gorman <mgorman@techsingularity.net>
Link: https://lore.kernel.org/r/20200218144534.4564-1-vincent.guittot@linaro.org

parent c5f86891

kernel/sched/fair.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -8337,6 +8337,8 @@ static inline void update_sg_wakeup_stats(struct sched_domain *sd,

		sgs->group_capacity = group->sgc->capacity;

		sgs->group_weight = group->group_weight;

		sgs->group_type = group_classify(sd->imbalance_pct, group, sgs);

		/*

Admin message