Commit 2896ee37 authored by David Teigland's avatar David Teigland Committed by Steven Whitehouse
Browse files

[DLM] fix add_requestqueue checking nodes list 



Requests that arrive after recovery has started are saved in the
requestqueue and processed after recovery is done.  Some of these requests
are purged during recovery if they are from nodes that have been removed.
We move the purging of the requests (dlm_purge_requestqueue) to later in
the recovery sequence which allows the routine saving requests
(dlm_add_requestqueue) to avoid filtering out requests by nodeid since the
same will be done by the purge.  The current code has add_requestqueue
filtering by nodeid but doesn't hold any locks when accessing the list of
current nodes.  This also means that we need to call the purge routine
when the lockspace is being shut down since the add routine will not be
rejecting requests itself any more.

Signed-off-by: default avatarDavid Teigland <teigland@redhat.com>
Signed-off-by: default avatarSteven Whitehouse <swhiteho@redhat.com>
parent dcf3dd85

fs/dlm/lockspace.c

+2 −0
Original line number Diff line number Diff line
@@ -22,6 +22,7 @@ 
#include "memory.h"

#include "lock.h"

#include "recover.h"

#include "requestqueue.h"



#ifdef CONFIG_DLM_DEBUG

int dlm_create_debug_file(struct dlm_ls *ls);
@@ -684,6 +685,7 @@ static int release_lockspace(struct dlm_ls *ls, int force) 
	 * Free structures on any other lists

	 */



	dlm_purge_requestqueue(ls);

	kfree(ls->ls_recover_args);

	dlm_clear_free_entries(ls);

	dlm_clear_members(ls);

fs/dlm/recoverd.c

+8 −8
Original line number Diff line number Diff line
@@ -93,14 +93,6 @@ static int ls_recover(struct dlm_ls *ls, struct dlm_recover *rv) 
		goto fail;

	}



	/*

	 * Purge directory-related requests that are saved in requestqueue.

	 * All dir requests from before recovery are invalid now due to the dir

	 * rebuild and will be resent by the requesting nodes.

	 */



	dlm_purge_requestqueue(ls);



	/*

	 * Wait for all nodes to complete directory rebuild.

	 */
@@ -181,6 +173,14 @@ static int ls_recover(struct dlm_ls *ls, struct dlm_recover *rv) 


	dlm_release_root_list(ls);



	/*

	 * Purge directory-related requests that are saved in requestqueue.

	 * All dir requests from before recovery are invalid now due to the dir

	 * rebuild and will be resent by the requesting nodes.

	 */



	dlm_purge_requestqueue(ls);



	dlm_set_recover_status(ls, DLM_RS_DONE);

	error = dlm_recover_done_wait(ls);

	if (error) {

fs/dlm/requestqueue.c

+4 −3
Original line number Diff line number Diff line
@@ -36,9 +36,6 @@ int dlm_add_requestqueue(struct dlm_ls *ls, int nodeid, struct dlm_header *hd) 
	int length = hd->h_length;

	int rv = 0;



	if (dlm_is_removed(ls, nodeid))

		return 0;



	e = kmalloc(sizeof(struct rq_entry) + length, GFP_KERNEL);

	if (!e) {

		log_print("dlm_add_requestqueue: out of memory\n");
@@ -133,6 +130,10 @@ static int purge_request(struct dlm_ls *ls, struct dlm_message *ms, int nodeid) 
{

	uint32_t type = ms->m_type;



	/* the ls is being cleaned up and freed by release_lockspace */

	if (!ls->ls_count)

		return 1;



	if (dlm_is_removed(ls, nodeid))

		return 1;

CRA Git | Maintained and supported by SUSTech CRA and CCSE