Commit 288d5abe authored Aug 03, 2011 by Linus Torvalds

Boot up with usermodehelper disabled



The core device layer sends tons of uevent notifications for each device
it finds, and if the kernel has been built with a non-empty
CONFIG_UEVENT_HELPER_PATH that will make us try to execute the usermode
helper binary for all these events very early in the boot.

Not only won't the root filesystem even be mounted at that point, we
literally won't have necessarily even initialized all the process
handling data structures at that point, which causes no end of silly
problems even when the usermode helper doesn't actually succeed in
executing.

So just use our existing infrastructure to disable the usermodehelpers
to make the kernel start out with them disabled.  We enable them when
we've at least initialized stuff a bit.

Problems related to an uninitialized

	init_ipc_ns.ids[IPC_SHM_IDS].rw_mutex

reported by various people.

Reported-by: Manuel Lauss <manuel.lauss@googlemail.com>
Reported-by: Richard Weinberger <richard@nod.at>
Reported-by: Marc Zyngier <maz@misterjones.org>
Acked-by: Kay Sievers <kay.sievers@vrfy.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Vasiliy Kulikov <segoon@openwall.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 33f35f2a

init/main.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -369,9 +369,12 @@ static noinline void __init_refok rest_init(void)
		init_idle_bootup_task(current);
		preempt_enable_no_resched();
		schedule();
		preempt_disable();

		/* At this point, we can enable user mode helper functionality */
		usermodehelper_enable();

		/* Call into cpu_idle with preempt disabled */
		preempt_disable();
		cpu_idle();
		}

kernel/kmod.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -274,7 +274,7 @@ static void __call_usermodehelper(struct work_struct *work)
		* (used for preventing user land processes from being created after the user
		* land has been frozen during a system-wide hibernation or suspend operation).
		*/
		static int usermodehelper_disabled;
		static int usermodehelper_disabled = 1;

		/* Number of helpers running */
		static atomic_t running_helpers = ATOMIC_INIT(0);

Admin message