Commit 2880325b authored Dec 20, 2019 by Kai-Heng Feng Committed by Bjorn Helgaas Mar 19, 2020

PCI: Avoid ASMedia XHCI USB PME# from D0 defect

The ASMedia USB XHCI Controller claims to support generating PME# while
in D0:

  01:00.0 USB controller: ASMedia Technology Inc. Device 2142 (prog-if 30 [XHCI])
    Subsystem: SUNIX Co., Ltd. Device 312b
    Capabilities: [78] Power Management version 3
      Flags: PMEClk- DSI- D1- D2- AuxCurrent=55mA PME(D0+,D1-,D2-,D3hot-,D3cold-)
      Status: D0 NoSoftRst+ PME-Enable+ DSel=0 DScale=0 PME-

However PME# only gets asserted when plugging USB 2.0 or USB 1.1 devices,
but not for USB 3.0 devices.

Remove PCI_PM_CAP_PME_D0 to avoid using PME under D0.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=205919
Link: https://lore.kernel.org/r/20191219192006.16270-1-kai.heng.feng@canonical.com


Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

parent e3cdcfce

drivers/pci/quirks.c

+11 −0

Original line number	Diff line number	Diff line
		@@ -5461,3 +5461,14 @@ out_disable:
		DECLARE_PCI_FIXUP_CLASS_FINAL(PCI_VENDOR_ID_NVIDIA, 0x13b1,
		PCI_CLASS_DISPLAY_VGA, 8,
		quirk_reset_lenovo_thinkpad_p50_nvgpu);

		/*
		* Device [1b21:2142]
		* When in D0, PME# doesn't get asserted when plugging USB 3.0 device.
		*/
		static void pci_fixup_no_d0_pme(struct pci_dev *dev)
		{
		pci_info(dev, "PME# does not work under D0, disabling it\n");
		dev->pme_support &= ~(PCI_PM_CAP_PME_D0 >> PCI_PM_CAP_PME_SHIFT);
		}
		DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ASMEDIA, 0x2142, pci_fixup_no_d0_pme);

Admin message