Commit 28785f70 authored May 19, 2017 by Liu Bo Committed by David Sterba Jun 19, 2017

Btrfs: skip commit transaction if we don't have enough pinned bytes



We commit transaction in order to reclaim space from pinned bytes because
it could process delayed refs, and in may_commit_transaction(), we check
first if pinned bytes are enough for the required space, we then check if
that plus bytes reserved for delayed insert are enough for the required
space.

This changes the code to the above logic.

Fixes: b150a4f1 ("Btrfs: use a percpu to keep track of possibly pinned bytes")
Tested-by: Nikolay Borisov <nborisov@suse.com>
Reported-by: Nikolay Borisov <nborisov@suse.com>
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 4e2814ef

fs/btrfs/extent-tree.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4854,7 +4854,7 @@ static int may_commit_transaction(struct btrfs_fs_info *fs_info,

		spin_lock(&delayed_rsv->lock);
		if (percpu_counter_compare(&space_info->total_bytes_pinned,
		bytes - delayed_rsv->size) >= 0) {
		bytes - delayed_rsv->size) < 0) {
		spin_unlock(&delayed_rsv->lock);
		return -ENOSPC;
		}

Admin message