Unverified Commit 28735af3 authored Feb 05, 2018 by KaiChieh Chuang Committed by Mark Brown Feb 07, 2018

ASoC: dapm: fix debugfs read using path->connected



This fix a bug in dapm_widget_power_read_file(),
where it may sent opposite order of source/sink widget
into the p->connected().

for example,
static int connected_check(source, sink);
{"w_sink", NULL, "w_source", connected_check}

the dapm_widget_power_read_file() will query p->connected()
in following case
	p->conneted("w_source", "w_sink")
	p->conneted("w_sink", "w_source")
we should avoid the last case, since it's the wrong order (source/sink)
as declared in snd_soc_dapm_route.

Signed-off-by: KaiChieh Chuang <kaichieh.chuang@mediatek.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 4fbd8d19

sound/soc/soc-dapm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2026,7 +2026,7 @@ static ssize_t dapm_widget_power_read_file(struct file *file,
		snd_soc_dapm_for_each_direction(dir) {
		rdir = SND_SOC_DAPM_DIR_REVERSE(dir);
		snd_soc_dapm_widget_for_each_path(w, dir, p) {
		if (p->connected && !p->connected(w, p->node[rdir]))
		if (p->connected && !p->connected(p->source, p->sink))
		continue;

		if (!p->connect)

Admin message