Commit 2844f797 authored by Alexander Duyck's avatar Alexander Duyck Committed by David S. Miller
Browse files

igb: make rxcsum configuration seperate from multiqueue 



The igb driver was being incorrectly setup to only allow disabling receive
checksum if multiqueue was disabled.  This change corrects that so that
RXCSUM is configured regardless of queue configuration.

Signed-off-by: default avatarAlexander Duyck <alexander.h.duyck@intel.com>
Signed-off-by: default avatarJeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 3935358e

drivers/net/igb/e1000_defines.h

+1 −1
Original line number Diff line number Diff line
@@ -289,8 +289,8 @@ 
#define E1000_SCTL_DISABLE_SERDES_LOOPBACK 0x0400



/* Receive Checksum Control */

#define E1000_RXCSUM_IPOFL     0x00000100   /* IPv4 checksum offload */

#define E1000_RXCSUM_TUOFL     0x00000200   /* TCP / UDP checksum offload */

#define E1000_RXCSUM_IPPCSE    0x00001000   /* IP payload checksum enable */

#define E1000_RXCSUM_PCSD      0x00002000   /* packet checksum disabled */



/* Header split receive */

drivers/net/igb/igb_main.c

+11 −19
Original line number Diff line number Diff line
@@ -2236,28 +2236,20 @@ static void igb_configure_rx(struct igb_adapter *adapter) 
		mrqc |= (E1000_MRQC_RSS_FIELD_IPV6_UDP_EX |

			 E1000_MRQC_RSS_FIELD_IPV6_TCP_EX);





		wr32(E1000_MRQC, mrqc);



		/* Multiqueue and raw packet checksumming are mutually

		 * exclusive.  Note that this not the same as TCP/IP

		 * checksumming, which works fine. */

		rxcsum = rd32(E1000_RXCSUM);

		rxcsum |= E1000_RXCSUM_PCSD;

		wr32(E1000_RXCSUM, rxcsum);

	} else {

	} else if (adapter->vfs_allocated_count) {

		/* Enable multi-queue for sr-iov */

		if (adapter->vfs_allocated_count)

		wr32(E1000_MRQC, E1000_MRQC_ENABLE_VMDQ);

	}



	/* Enable Receive Checksum Offload for TCP and UDP */

	rxcsum = rd32(E1000_RXCSUM);

		if (adapter->rx_csum)

			rxcsum |= E1000_RXCSUM_TUOFL | E1000_RXCSUM_IPPCSE;

		else

			rxcsum &= ~(E1000_RXCSUM_TUOFL | E1000_RXCSUM_IPPCSE);



	/* Disable raw packet checksumming */

	rxcsum |= E1000_RXCSUM_PCSD;

	/* Don't need to set TUOFL or IPOFL, they default to 1 */

	if (!adapter->rx_csum)

		rxcsum &= ~(E1000_RXCSUM_TUOFL | E1000_RXCSUM_IPOFL);

	wr32(E1000_RXCSUM, rxcsum);

	}



	/* Set the default pool for the PF's first queue */

	igb_configure_vt_default_pool(adapter);

CRA Git | Maintained and supported by SUSTech CRA and CCSE