Commit 284441a9 authored Jul 05, 2019 by Hou Zhiqiang Committed by Lorenzo Pieralisi Jul 08, 2019

PCI: mobiveil: Move IRQ chained handler setup out of DT parse



The irq_set_chained_handler_and_data() call is not dependent on device
tree firmware so it should be moved out of the DT parsing function for
clarity.

Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
[lorenzo.pieralisi@arm.com: rewritten commit log]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Minghuan Lian <Minghuan.Lian@nxp.com>
Reviewed-by: Subrahmanya Lingappa <l.subrahmanya@mobiveil.co.in>

parent 40af900c

drivers/pci/controller/pcie-mobiveil.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -446,8 +446,6 @@ static int mobiveil_pcie_parse_dt(struct mobiveil_pcie *pcie)
		return -ENODEV;
		}

		irq_set_chained_handler_and_data(pcie->irq, mobiveil_pcie_isr, pcie);

		return 0;
		}

		@@ -872,6 +870,8 @@ static int mobiveil_pcie_probe(struct platform_device *pdev)
		goto error;
		}

		irq_set_chained_handler_and_data(pcie->irq, mobiveil_pcie_isr, pcie);

		ret = devm_request_pci_bus_resources(dev, &pcie->resources);
		if (ret)
		goto error;

Admin message