Commit 2840f84f authored Dec 10, 2018 by Steven Rostedt (VMware)

tracing: Fix memory leak of instance function hash filters



The following commands will cause a memory leak:

 # cd /sys/kernel/tracing
 # mkdir instances/foo
 # echo schedule > instance/foo/set_ftrace_filter
 # rmdir instances/foo

The reason is that the hashes that hold the filters to set_ftrace_filter and
set_ftrace_notrace are not freed if they contain any data on the instance
and the instance is removed.

Found by kmemleak detector.

Cc: stable@vger.kernel.org
Fixes: 591dffda ("ftrace: Allow for function tracing instance to filter functions")
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

parent 3cec638b

kernel/trace/ftrace.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -5460,6 +5460,7 @@ void ftrace_destroy_filter_files(struct ftrace_ops *ops)
		if (ops->flags & FTRACE_OPS_FL_ENABLED)
		ftrace_shutdown(ops, 0);
		ops->flags \|= FTRACE_OPS_FL_DELETED;
		ftrace_free_filter(ops);
		mutex_unlock(&ftrace_lock);
		}

Admin message