Commit 281243cb authored by Marc Zyngier's avatar Marc Zyngier
Browse files

arm64: KVM: debug: Remove spurious inline attributes 



The debug trapping code is pretty heavy on the "inline" attribute,
but most functions are actually referenced in the sysreg tables,
making the inlining imposible.

Removing the useless inline qualifier seems the right thing to do,
having verified that the output code is similar.

Cc: Alex Bennée <alex.bennee@linaro.org>
Acked-by: default avatarChristoffer Dall <christoffer.dall@linaro.org>
Signed-off-by: default avatarMarc Zyngier <marc.zyngier@arm.com>
parent e078ef81

arch/arm64/kvm/sys_regs.c

+29 −29
Original line number Diff line number Diff line
@@ -220,7 +220,7 @@ static bool trap_debug_regs(struct kvm_vcpu *vcpu, 
 * All writes will set the KVM_ARM64_DEBUG_DIRTY flag to ensure the

 * hyp.S code switches between host and guest values in future.

 */

static inline void reg_to_dbg(struct kvm_vcpu *vcpu,

static void reg_to_dbg(struct kvm_vcpu *vcpu,

		       struct sys_reg_params *p,

		       u64 *dbg_reg)

{
@@ -235,7 +235,7 @@ static inline void reg_to_dbg(struct kvm_vcpu *vcpu, 
	vcpu->arch.debug_flags |= KVM_ARM64_DEBUG_DIRTY;

}



static inline void dbg_to_reg(struct kvm_vcpu *vcpu,

static void dbg_to_reg(struct kvm_vcpu *vcpu,

		       struct sys_reg_params *p,

		       u64 *dbg_reg)

{
@@ -244,7 +244,7 @@ static inline void dbg_to_reg(struct kvm_vcpu *vcpu, 
		p->regval &= 0xffffffffUL;

}



static inline bool trap_bvr(struct kvm_vcpu *vcpu,

static bool trap_bvr(struct kvm_vcpu *vcpu,

		     struct sys_reg_params *p,

		     const struct sys_reg_desc *rd)

{
@@ -280,13 +280,13 @@ static int get_bvr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *rd, 
	return 0;

}



static inline void reset_bvr(struct kvm_vcpu *vcpu,

static void reset_bvr(struct kvm_vcpu *vcpu,

		      const struct sys_reg_desc *rd)

{

	vcpu->arch.vcpu_debug_state.dbg_bvr[rd->reg] = rd->val;

}



static inline bool trap_bcr(struct kvm_vcpu *vcpu,

static bool trap_bcr(struct kvm_vcpu *vcpu,

		     struct sys_reg_params *p,

		     const struct sys_reg_desc *rd)

{
@@ -323,13 +323,13 @@ static int get_bcr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *rd, 
	return 0;

}



static inline void reset_bcr(struct kvm_vcpu *vcpu,

static void reset_bcr(struct kvm_vcpu *vcpu,

		      const struct sys_reg_desc *rd)

{

	vcpu->arch.vcpu_debug_state.dbg_bcr[rd->reg] = rd->val;

}



static inline bool trap_wvr(struct kvm_vcpu *vcpu,

static bool trap_wvr(struct kvm_vcpu *vcpu,

		     struct sys_reg_params *p,

		     const struct sys_reg_desc *rd)

{
@@ -366,13 +366,13 @@ static int get_wvr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *rd, 
	return 0;

}



static inline void reset_wvr(struct kvm_vcpu *vcpu,

static void reset_wvr(struct kvm_vcpu *vcpu,

		      const struct sys_reg_desc *rd)

{

	vcpu->arch.vcpu_debug_state.dbg_wvr[rd->reg] = rd->val;

}



static inline bool trap_wcr(struct kvm_vcpu *vcpu,

static bool trap_wcr(struct kvm_vcpu *vcpu,

		     struct sys_reg_params *p,

		     const struct sys_reg_desc *rd)

{
@@ -408,7 +408,7 @@ static int get_wcr(struct kvm_vcpu *vcpu, const struct sys_reg_desc *rd, 
	return 0;

}



static inline void reset_wcr(struct kvm_vcpu *vcpu,

static void reset_wcr(struct kvm_vcpu *vcpu,

		      const struct sys_reg_desc *rd)

{

	vcpu->arch.vcpu_debug_state.dbg_wcr[rd->reg] = rd->val;
@@ -723,7 +723,7 @@ static bool trap_debug32(struct kvm_vcpu *vcpu, 
 * system is in.

 */



static inline bool trap_xvr(struct kvm_vcpu *vcpu,

static bool trap_xvr(struct kvm_vcpu *vcpu,

		     struct sys_reg_params *p,

		     const struct sys_reg_desc *rd)

{

CRA Git | Maintained and supported by SUSTech CRA and CCSE