mm/mmap.c: change __install_special_mapping() args order (27f28b97) · Commits · 戴 / test

Make __install_special_mapping() args order match the caller, so the caller can pass their register args directly to callee with no touch. For most of architectures, args (at least the first 5th args) are in registers, so this change will have effect on most of architectures. For -O2, __install_special_mapping() may be inlined under most of architectures, but for -Os, it should not. So this change can get a little better performance for -Os, at least. Signed-off-by:

Chen Gang <gang.chen.5i5j@gmail.com> Signed-off-by:

Andrew Morton <akpm@linux-foundation.org> Signed-off-by:

Linus Torvalds <torvalds@linux-foundation.org>

mm/mmap.c

+6 −6

Original line number	Diff line number	Diff line
		@@ -3052,8 +3052,8 @@ static int special_mapping_fault(struct vm_area_struct *vma,
		static struct vm_area_struct *__install_special_mapping(
		struct mm_struct *mm,
		unsigned long addr, unsigned long len,
		unsigned long vm_flags, const struct vm_operations_struct *ops,
		void *priv)
		unsigned long vm_flags, void *priv,
		const struct vm_operations_struct *ops)
		{
		int ret;
		struct vm_area_struct *vma;
		@@ -3102,8 +3102,8 @@ struct vm_area_struct *_install_special_mapping(
		unsigned long addr, unsigned long len,
		unsigned long vm_flags, const struct vm_special_mapping *spec)
		{
		return __install_special_mapping(mm, addr, len, vm_flags,
		&special_mapping_vmops, (void *)spec);
		return __install_special_mapping(mm, addr, len, vm_flags, (void *)spec,
		&special_mapping_vmops);
		}

		int install_special_mapping(struct mm_struct *mm,
		@@ -3111,8 +3111,8 @@ int install_special_mapping(struct mm_struct *mm,
		unsigned long vm_flags, struct page **pages)
		{
		struct vm_area_struct *vma = __install_special_mapping(
		mm, addr, len, vm_flags, &legacy_special_mapping_vmops,
		(void *)pages);
		mm, addr, len, vm_flags, (void *)pages,
		&legacy_special_mapping_vmops);

		return PTR_ERR_OR_ZERO(vma);
		}

Admin message