Commit 27da0d2e authored Mar 06, 2019 by Arnd Bergmann Committed by David S. Miller Mar 06, 2019

appletalk: Fix compile regression



A bugfix just broke compilation of appletalk when CONFIG_SYSCTL
is disabled:

In file included from net/appletalk/ddp.c:65:
net/appletalk/ddp.c: In function 'atalk_init':
include/linux/atalk.h:164:34: error: expected expression before 'do'
 #define atalk_register_sysctl()  do { } while(0)
                                  ^~
net/appletalk/ddp.c:1934:7: note: in expansion of macro 'atalk_register_sysctl'
  rc = atalk_register_sysctl();

This is easier to avoid by using conventional inline functions
as stubs rather than macros. The header already has inline
functions for other purposes, so I'm changing over all the
macros for consistency.

Fixes: 6377f787 ("appletalk: Fix use-after-free in atalk_proc_exit")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f4b3ec4e

include/linux/atalk.h

+14 −4

Original line number	Diff line number	Diff line
		@@ -161,16 +161,26 @@ extern int sysctl_aarp_resolve_time;
		extern int atalk_register_sysctl(void);
		extern void atalk_unregister_sysctl(void);
		#else
		#define atalk_register_sysctl() do { } while(0)
		#define atalk_unregister_sysctl() do { } while(0)
		static inline int atalk_register_sysctl(void)
		{
		return 0;
		}
		static inline void atalk_unregister_sysctl(void)
		{
		}
		#endif

		#ifdef CONFIG_PROC_FS
		extern int atalk_proc_init(void);
		extern void atalk_proc_exit(void);
		#else
		#define atalk_proc_init() ({ 0; })
		#define atalk_proc_exit() do { } while(0)
		static inline int atalk_proc_init(void)
		{
		return 0;
		}
		static inline void atalk_proc_exit(void)
		{
		}
		#endif /* CONFIG_PROC_FS */

		#endif /* __LINUX_ATALK_H__ */

Admin message