Commit 27d61629 authored Oct 04, 2017 by Stuart Hayes Committed by Bjorn Helgaas Oct 10, 2017

PCI: Create SR-IOV virtfn/physfn links before attaching driver

When creating virtual functions, create the "virtfn%u" and "physfn" links
in sysfs *before* attaching the driver instead of after. When we attach
the driver to the new virtual network interface first, there is a race when
the driver attaches to the new sends out an "add" udev event, and the
network interface naming software (biosdevname or systemd, for example)
tries to look at these links.

Signed-off-by: Stuart Hayes <stuart.w.hayes@gmail.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>

parent 7dfca152

drivers/pci/iov.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -159,7 +159,6 @@ int pci_iov_add_virtfn(struct pci_dev *dev, int id)

		pci_device_add(virtfn, virtfn->bus);

		pci_bus_add_device(virtfn);
		sprintf(buf, "virtfn%u", id);
		rc = sysfs_create_link(&dev->dev.kobj, &virtfn->dev.kobj, buf);
		if (rc)
		@@ -170,6 +169,8 @@ int pci_iov_add_virtfn(struct pci_dev *dev, int id)

		kobject_uevent(&virtfn->dev.kobj, KOBJ_CHANGE);

		pci_bus_add_device(virtfn);

		return 0;

		failed2:

Admin message