Commit 27d0fd41 authored by Arnaldo Carvalho de Melo's avatar Arnaldo Carvalho de Melo Committed by Ingo Molnar
Browse files

strlist: Introduce strlist__entry and strlist__nr_entries methods 



The strlist__entry method allows accessing strlists like an
array, will be used in the 'perf report' to access the first
entry.

We now keep the nr_entries so that we can check if we have just
one entry, will be used in 'perf report' to improve the output
by showing just at the top when we have just, say, one DSO.

While at it use nr_entries to optimize strlist__is_empty by not
using the far more costly rb_first based implementation.

Signed-off-by: default avatarArnaldo Carvalho de Melo <acme@redhat.com>
LKML-Reference: <1247325517-12272-2-git-send-email-acme@redhat.com>
Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
parent 60c1baf1

tools/perf/util/strlist.c

+18 −2
Original line number Diff line number Diff line
@@ -64,6 +64,7 @@ int strlist__add(struct strlist *self, const char *new_entry) 


	rb_link_node(&sn->rb_node, parent, p);

	rb_insert_color(&sn->rb_node, &self->entries);

	++self->nr_entries;



	return 0;

}
@@ -157,6 +158,7 @@ struct strlist *strlist__new(bool dupstr, const char *slist) 
	if (self != NULL) {

		self->entries	 = RB_ROOT;

		self->dupstr	 = dupstr;

		self->nr_entries = 0;

		if (slist && strlist__parse_list(self, slist) != 0)

			goto out_error;

	}
@@ -182,3 +184,17 @@ void strlist__delete(struct strlist *self) 
		free(self);

	}

}



struct str_node *strlist__entry(const struct strlist *self, unsigned int idx)

{

	struct rb_node *nd;



	for (nd = rb_first(&self->entries); nd; nd = rb_next(nd)) {

		struct str_node *pos = rb_entry(nd, struct str_node, rb_node);



		if (!idx--)

			return pos;

	}



	return NULL;

}

tools/perf/util/strlist.h

+9 −2
Original line number Diff line number Diff line
@@ -11,6 +11,7 @@ struct str_node { 


struct strlist {

	struct rb_root entries;

	unsigned int   nr_entries;

	bool	       dupstr;

};
@@ -21,11 +22,17 @@ void strlist__remove(struct strlist *self, struct str_node *sn); 
int strlist__load(struct strlist *self, const char *filename);

int strlist__add(struct strlist *self, const char *str);



struct str_node *strlist__entry(const struct strlist *self, unsigned int idx);

bool strlist__has_entry(struct strlist *self, const char *entry);



static inline bool strlist__empty(const struct strlist *self)

{

	return rb_first(&self->entries) == NULL;

	return self->nr_entries == 0;

}



static inline unsigned int strlist__nr_entries(const struct strlist *self)

{

	return self->nr_entries;

}



int strlist__parse_list(struct strlist *self, const char *s);

CRA Git | Maintained and supported by SUSTech CRA and CCSE