Commit 278df9f4 authored by Minchan Kim's avatar Minchan Kim Committed by Linus Torvalds
Browse files

mm: reclaim invalidated page ASAP 



invalidate_mapping_pages is very big hint to reclaimer.  It means user
doesn't want to use the page any more.  So in order to prevent working set
page eviction, this patch move the page into tail of inactive list by
PG_reclaim.

Please, remember that pages in inactive list are working set as well as
active list.  If we don't move pages into inactive list's tail, pages near
by tail of inactive list can be evicted although we have a big clue about
useless pages.  It's totally bad.

Now PG_readahead/PG_reclaim is shared.  fe3cba17 added ClearPageReclaim
into clear_page_dirty_for_io for preventing fast reclaiming readahead
marker page.

In this series, PG_reclaim is used by invalidated page, too.  If VM find
the page is invalidated and it's dirty, it sets PG_reclaim to reclaim
asap.  Then, when the dirty page will be writeback,
clear_page_dirty_for_io will clear PG_reclaim unconditionally.  It
disturbs this serie's goal.

I think it's okay to clear PG_readahead when the page is dirty, not
writeback time.  So this patch moves ClearPageReadahead.  In v4,
ClearPageReadahead in set_page_dirty has a problem which is reported by
Steven Barrett.  It's due to compound page.  Some driver(ex, audio) calls
set_page_dirty with compound page which isn't on LRU.  but my patch does
ClearPageRelcaim on compound page.  In non-CONFIG_PAGEFLAGS_EXTENDED, it
breaks PageTail flag.

I think it doesn't affect THP and pass my test with THP enabling but Cced
Andrea for double check.

Signed-off-by: default avatarMinchan Kim <minchan.kim@gmail.com>
Reported-by: default avatarSteven Barrett <damentz@liquorix.net>
Reviewed-by: default avatarJohannes Weiner <hannes@cmpxchg.org>
Acked-by: default avatarRik van Riel <riel@redhat.com>
Acked-by: default avatarMel Gorman <mel@csn.ul.ie>
Cc: Wu Fengguang <fengguang.wu@intel.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Nick Piggin <npiggin@kernel.dk>
Cc: Andrea Arcangeli <aarcange@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 3f58a829

mm/page-writeback.c

+11 −1
Original line number Diff line number Diff line
@@ -1211,6 +1211,17 @@ int set_page_dirty(struct page *page) 


	if (likely(mapping)) {

		int (*spd)(struct page *) = mapping->a_ops->set_page_dirty;

		/*

		 * readahead/lru_deactivate_page could remain

		 * PG_readahead/PG_reclaim due to race with end_page_writeback

		 * About readahead, if the page is written, the flags would be

		 * reset. So no problem.

		 * About lru_deactivate_page, if the page is redirty, the flag

		 * will be reset. So no problem. but if the page is used by readahead

		 * it will confuse readahead and make it restart the size rampup

		 * process. But it's a trivial problem.

		 */

		ClearPageReclaim(page);

#ifdef CONFIG_BLOCK

		if (!spd)

			spd = __set_page_dirty_buffers;
@@ -1266,7 +1277,6 @@ int clear_page_dirty_for_io(struct page *page) 


	BUG_ON(!PageLocked(page));



	ClearPageReclaim(page);

	if (mapping && mapping_cap_account_dirty(mapping)) {

		/*

		 * Yes, Virginia, this is indeed insane.

mm/swap.c

+38 −3
Original line number Diff line number Diff line
@@ -354,26 +354,61 @@ void add_page_to_unevictable_list(struct page *page) 
 * head of the list, rather than the tail, to give the flusher

 * threads some time to write it out, as this is much more

 * effective than the single-page writeout from reclaim.

 *

 * If the page isn't page_mapped and dirty/writeback, the page

 * could reclaim asap using PG_reclaim.

 *

 * 1. active, mapped page -> none

 * 2. active, dirty/writeback page -> inactive, head, PG_reclaim

 * 3. inactive, mapped page -> none

 * 4. inactive, dirty/writeback page -> inactive, head, PG_reclaim

 * 5. inactive, clean -> inactive, tail

 * 6. Others -> none

 *

 * In 4, why it moves inactive's head, the VM expects the page would

 * be write it out by flusher threads as this is much more effective

 * than the single-page writeout from reclaim.

 */

static void lru_deactivate(struct page *page, struct zone *zone)

{

	int lru, file;

	bool active;



	if (!PageLRU(page) || !PageActive(page))

	if (!PageLRU(page))

		return;



	/* Some processes are using the page */

	if (page_mapped(page))

		return;



	active = PageActive(page);



	file = page_is_file_cache(page);

	lru = page_lru_base_type(page);

	del_page_from_lru_list(zone, page, lru + LRU_ACTIVE);

	del_page_from_lru_list(zone, page, lru + active);

	ClearPageActive(page);

	ClearPageReferenced(page);

	add_page_to_lru_list(zone, page, lru);

	__count_vm_event(PGDEACTIVATE);



	if (PageWriteback(page) || PageDirty(page)) {

		/*

		 * PG_reclaim could be raced with end_page_writeback

		 * It can make readahead confusing.  But race window

		 * is _really_ small and  it's non-critical problem.

		 */

		SetPageReclaim(page);

	} else {

		/*

		 * The page's writeback ends up during pagevec

		 * We moves tha page into tail of inactive.

		 */

		list_move_tail(&page->lru, &zone->lru[lru].list);

		mem_cgroup_rotate_reclaimable_page(page);

		__count_vm_event(PGROTATED);

	}



	if (active)

		__count_vm_event(PGDEACTIVATE);

	update_page_reclaim_stat(zone, page, file, 0);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE