Commit 277fb5fc authored Aug 19, 2015 by Michal Hocko Committed by Chris Mason Aug 19, 2015

btrfs: use __GFP_NOFAIL in alloc_btrfs_bio



alloc_btrfs_bio relies on GFP_NOFS allocation when committing the
transaction but this allocation context is rather weak wrt. reclaim
capabilities. The page allocator currently tries hard to not fail these
allocations if they are small (<=PAGE_ALLOC_COSTLY_ORDER) but it can
still fail if the _current_ process is the OOM killer victim. Moreover
there is an attempt to move away from the default no-fail behavior and
allow these allocation to fail more eagerly. This would lead to:

[   37.928625] kernel BUG at fs/btrfs/extent_io.c:4045

which is clearly undesirable and the nofail behavior should be explicit
if the allocation failure cannot be tolerated.

Signed-off-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Chris Mason <clm@fb.com>

parent d1b5c567

fs/btrfs/volumes.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -5082,9 +5082,7 @@ static struct btrfs_bio *alloc_btrfs_bio(int total_stripes, int real_stripes)
		* and the stripes
		*/
		sizeof(u64) * (total_stripes),
		GFP_NOFS);
		if (!bbio)
		return NULL;
		GFP_NOFS\|__GFP_NOFAIL);

		atomic_set(&bbio->error, 0);
		atomic_set(&bbio->refs, 1);

Admin message