Commit 277c628f authored Jul 02, 2019 by Christian Schneider Committed by Guenter Roeck Jul 08, 2019

hwmon: (gpio-fan) fix sysfs notifications and udev events for gpio-fan alarms

sysfs_notify() and kobject_uevent() are passed the wrong device.
fan_data->hwmon_dev needs to be passed, so that sysfs notification
goes to right place and generated uevent has the right information

Signed-off-by: Christian Schneider <cschneider@radiodata.biz>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent f2173fa2

drivers/hwmon/gpio-fan.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -54,8 +54,8 @@ static void fan_alarm_notify(struct work_struct *ws)
		struct gpio_fan_data *fan_data =
		container_of(ws, struct gpio_fan_data, alarm_work);

		sysfs_notify(&fan_data->dev->kobj, NULL, "fan1_alarm");
		kobject_uevent(&fan_data->dev->kobj, KOBJ_CHANGE);
		sysfs_notify(&fan_data->hwmon_dev->kobj, NULL, "fan1_alarm");
		kobject_uevent(&fan_data->hwmon_dev->kobj, KOBJ_CHANGE);
		}

		static irqreturn_t fan_alarm_irq_handler(int irq, void *dev_id)

Admin message