Commit 27777daa authored Jun 20, 2016 by Jon Paul Maloy Committed by David S. Miller Jun 22, 2016

tipc: unclone unbundled buffers before forwarding



When extracting an individual message from a received "bundle" buffer,
we just create a clone of the base buffer, and adjust it to point into
the right position of the linearized data area of the latter. This works
well for regular message reception, but during periods of extremely high
load it may happen that an extracted buffer, e.g, a connection probe, is
reversed and forwarded through an external interface while the preceding
extracted message is still unhandled. When this happens, the header or
data area of the preceding message will be partially overwritten by a
MAC header, leading to unpredicatable consequences, such as a link
reset.

We now fix this by ensuring that the msg_reverse() function never
returns a cloned buffer, and that the returned buffer always contains
sufficient valid head and tail room to be forwarded.

Reported-by: Erik Hugne <erik.hugne@gmail.com>
Acked-by: Ying Xue <ying.xue@windriver.com>
Signed-off-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d19af0a7

net/tipc/msg.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -41,6 +41,8 @@
		#include "name_table.h"

		#define MAX_FORWARD_SIZE 1024
		#define BUF_HEADROOM (LL_MAX_HEADER + 48)
		#define BUF_TAILROOM 16

		static unsigned int align(unsigned int i)
		{
		@@ -505,6 +507,10 @@ bool tipc_msg_reverse(u32 own_node, struct sk_buff **skb, int err)
		msg_set_hdr_sz(hdr, BASIC_H_SIZE);
		}

		if (skb_cloned(_skb) &&
		pskb_expand_head(_skb, BUF_HEADROOM, BUF_TAILROOM, GFP_KERNEL))
		goto exit;

		/* Now reverse the concerned fields */
		msg_set_errcode(hdr, err);
		msg_set_origport(hdr, msg_destport(&ohdr));

net/tipc/msg.h

+0 −11

Original line number	Diff line number	Diff line
		@@ -94,17 +94,6 @@ struct plist;

		#define TIPC_MEDIA_INFO_OFFSET 5

		/**
		* TIPC message buffer code
		*
		* TIPC message buffer headroom reserves space for the worst-case
		* link-level device header (in case the message is sent off-node).
		*
		* Note: Headroom should be a multiple of 4 to ensure the TIPC header fields
		* are word aligned for quicker access
		*/
		#define BUF_HEADROOM (LL_MAX_HEADER + 48)

		struct tipc_skb_cb {
		void *handle;
		struct sk_buff *tail;

Admin message