Commit 275f6010 authored Nov 17, 2020 by Kaixu Xia Committed by Marc Kleine-Budde Nov 20, 2020

can: mcp251xfd: remove useless code in mcp251xfd_chip_softreset



It would directly return if the variable err equals to 0 or other errors.
Only when the err equals to -ETIMEDOUT it can reach the 'if (err)'
statement, so the 'if (err)' and last 'return -ETIMEDOUT' statements are
useless. Romove them.

Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
Link: https://lore.kernel.org/r/1605605352-25298-1-git-send-email-kaixuxia@tencent.com


Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>

parent 887e5a9a

drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -644,10 +644,7 @@ static int mcp251xfd_chip_softreset(const struct mcp251xfd_priv *priv)
		return 0;
		}

		if (err)
		return err;

		return -ETIMEDOUT;
		}

		static int mcp251xfd_chip_clock_init(const struct mcp251xfd_priv *priv)

Admin message